-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet verification on Desktop and Android should parity one another #13220
Comments
Another good example of this: |
Exact report of this issue: +1 https://www.reddit.com/r/brave_browser/comments/kuf6zw/verify_wallet/ |
Removed Bigger problem here though:
Root problem (for showing notification) is to avoiding new signs up for people that don't already have an account |
I believe this would affect I agree that the login button should also exist on Android, in the same way it exists on desktop. @jenn-rhim also confirmed on Nov 13, 2020 that the dialog boxes should be the same on both platforms: i.e., that both Android and desktop should have the "login" option as desktop does. It should look like this (from Jenn): |
+1 No ability to backup/restore: https://old.reddit.com/r/BATProject/comments/l3xinc/what_happens_to_bat_if_i_uninstall_brave_apk/ |
cc: @brave/android |
@jenn-rhim @Miyayes i think i can follow this UI. Do you have any concerns ? what should happen when user clicks on login ? |
"Login" on desktop sends them here (some numbers were redacted). cc: @deeppandya It should send them to the same URL/flow! |
Thanks @Miyayes I will update it. |
So any news? |
@deeppandya @zenparsing what are the desktop and android test plans for this issue? Adding |
|
@deeppandya can you confirm this is sufficient for Android #15196 (comment)? If there are any other cases to be verified please mention in the test plan and I will retest #15196 |
cc @zenparsing for desktop test plan. Is desktop testing needed for this issue? |
@deeppandya did you make any desktop changes? wondering if I can remove the |
@LaurenWags I haven't updated anything for desktop. I have added login flow for Android only. |
thanks @deeppandya. Per discussion in the desktop planning mtg (5/18), I'm removing the |
Verification passed on OnePlus 6T with Android 10 running 1.25.60 x64 Beta Build
Verification passed on Samsung Tab A with Android 10 running 1.25.60 x64 Beta Build
|
Description
Note: This issue was carried over from internal support repo, as requested by @marshall.
“Verify wallet” flow is inconsistent between Android and desktop, and messaging/UX regarding the 25 BAT minimum can be improved. Below is a description of the current flow when pressing “verify wallet”:
Desktop flow:
Verify wallet --> Login
and log into their Uphold account using standard Uphold flow, and then the wallet will be verified.Verify wallet
and login to their Uphold account without meeting that 25BAT requirement.Android flow:
If a user, with or without a verified Uphold account:
verify wallet
option in Brave Rewards panel -- if they do not have 25BAT minimum in their browser wallet, they will receive a notification that 25BAT is required in order to verify/link their Android wallet with Uphold.verify wallet
option in Brave Rewards panel -- if they have 25BAT minimum requirement, they are then taken to the Uphold signup/login flow.Android users have a rigid restriction to wallet verification (must have 25 BAT) whereas Desktop users see more of a "suggestion" rather than facing a real restriction. This discrepancy can be confusing to users, especially now that Desktop users also receive “25 BAT minimum” messaging.
We do not want to impose a strict 25 BAT minimum because some users will want to restore existing Uphold accounts for legitimate reasons (e.g., backup/restore). However, we also do not want to encourage users with less than 25 BAT to sign up with Uphold.
Proposed changes
Proposal 1 - Changing messaging on pop-up, and make it consistent on both Desktop and Android platforms
Change messaging text to:
Change Android notification to match messaging/notification in Desktop and display “Login” option
This will, at minimum, keep parity between platforms and also make it more clear that we are referring specifically to users who are new/do not have a current verified Uphold account. Additionally, it would allow Android users to have a reliable way to “backup” their BAT should something happen to their device.
Both platforms would display the same pop-up/messaging:
Proposal 2:
This retains users’ ability to restore an existing Uphold account for backup/restore reasons, while discouraging new users from creating/linking new Uphold accounts if they have less than 25 BAT. This recasts the “login” button as a backup/restore functionality, and keeps the messaging clear.
A combination of both of proposals is another possibility (change messaging text and move UI items as described in proposal 2).
The text was updated successfully, but these errors were encountered: