Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to pick active tab title font weight #13164

Closed
rubenpoppe opened this issue Dec 11, 2020 · 7 comments
Closed

Option to pick active tab title font weight #13164

rubenpoppe opened this issue Dec 11, 2020 · 7 comments

Comments

@rubenpoppe
Copy link

rubenpoppe commented Dec 11, 2020

Description

Active tab title now is in semibold instead of the previous regular.
image
I would like the option to pick the active tab title font weight.

Steps to Reproduce

  1. Open a tab
  2. Be active on tab

Actual result:

Active tab title in semibold

Expected result:

Option to choose font weight (regular/semibold) in settings->appearance

Reproduces how often:

Standard behavior

Brave version (brave://version info)

Version 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    Not sure
  • Can you reproduce this issue with the nightly channel?
    Not sure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Does the issue resolve itself when disabling Brave Rewards?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No

Miscellaneous Information:

No further info

@rubenpoppe rubenpoppe changed the title Option to pick active tab font weight Option to pick active tab title font weight Dec 11, 2020
@ghost
Copy link

ghost commented Dec 12, 2020

@rubenpoppe so basically you want the ability to configure how bold the title of a new tab is? Right now, it is the default for whatever brave has it set at but you think it would be nice to have an option in settings to change how bold an active tabs title is?

@rubenpoppe
Copy link
Author

@bamacyber yes it's basically that. It came to mind due to the recent change in Brave Version 1.18.70.

@ghost
Copy link

ghost commented Dec 12, 2020

@rubenpoppe ok. Can you update me on the recent change you are referring to? I am new to contributing to this particular part of brave. Also, I started some discussion around your feature request so we could get the communities input 🙂
https://community.brave.com/t/active-title-bold-weight-settings/187233

@rubenpoppe
Copy link
Author

It was just the latest release (1.18.70). Release notes can be found on the Brave Release Channel. Issue around the topic is #8576.

@mariansam
Copy link

Maybe it's just my opinion, but I think the new design is ugly. It was the first thing that hit me when I updated Brave few days ago. I understand the reason and it may make sense that this would be the default. But I'd love to change this to the old design. Unfortunately I don't think Brave/Chromium has something like Firefox's userChrome.css/userContent.css, which would solve this...
image

@rubenpoppe
Copy link
Author

It might get slightly better. Check out #13174.

@rebron
Copy link
Collaborator

rebron commented Dec 15, 2020

@rubenpoppe We're going to close this one out as we're addressing the font-weight issue via #13174. For options to change font-weight, that's more appropriate as an extension.

@mariansam Thanks for your comment. We updated the design to make the tab you're on stand out more. We hid the [x] on the other tabs so you can see more of the page title for background tabs. Seeing all those [x] is redundant and a mouseover shows the [x]. Change and slight changes are tough some times especially for things we're used to, but I think what we changed is a better design in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants