-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] Do not connect to accounts.google.com on enabling sync-v2 #12984
[Security] Do not connect to accounts.google.com on enabling sync-v2 #12984
Comments
cc @darkdh |
Fix being discussed here: https://bravesoftware.slack.com/archives/C2HJYB45N/p1606867060133000 |
Also reproducible on stable
and beta
|
Re-opening since it was reverted due to a windows build failure here: brave/brave-core#7470 |
Verification is in-progress
Reproduced the issue in 1.19.86 Issue is fixed in 1.20.86 - ensured that the
Reproduced the issue in 1.19.86 Issue is fixed in 1.20.86 - ensured that the Verification passed on
Verified test plan from the description Verified test plan from brave/brave-core#7480 Verified also on macOS, using the testplan from brave/brave-core#7480 Reproduced the issue in release, using:
Then verified it's FIXED, using:
Finally, a comparison of the two: |
This still isn't fixed. At least on Android. Any good reason this was looked over? |
Description
A request to accounts.google.com is initiated when enabling sync.
Steps to Reproduce
Actual result:
Request to accounts.google.com initiated
Expected result:
Should not be initiated
Reproduces how often:
Easily
Brave version (brave://version info)
1.19.33 Chromium: 87.0.4280.67 (Official Build) nightly (x86_64)
Version/Channel Information:
The text was updated successfully, but these errors were encountered: