Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes page loading bypasses Tor network #12800

Closed
btlechowski opened this issue Nov 19, 2020 · 3 comments
Closed

Sometimes page loading bypasses Tor network #12800

btlechowski opened this issue Nov 19, 2020 · 3 comments
Labels
bug feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor intermittent-issue OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.19.x - Release

Comments

@btlechowski
Copy link

btlechowski commented Nov 19, 2020 •
edited
Loading

The page is loaded normally in Tor Window

This is not a regression

Steps to Reproduce

  1. Clean profile
  2. Open Tor Window and immediately close it
  3. Open Tor Window
  4. Open check.torproject.org

Note: check the recording

tor_fail

Actual result:

Page bypasses Tor network
Page is loaded normally
image

Expected result:

Page is always loaded through Tor network

Reproduces how often:

Intermittent issue

Brave version (brave://version info)

Reproduced on

Brave 1.16.76 Chromium: 86.0.4240.198 (Official Build) (64-bit)
Revision d8a506935fc2273cfbac5e5b629d74917d9119c7-refs/branch-heads/4240@{#1431}
OS Ubuntu 18.04 LTS
Tor 1.0.12
Brave 1.17.71 Chromium: 87.0.4280.66 (Official Build) (64-bit)
Revision fd98a29dd59b36f71e4741332c9ad5bda42094bf-refs/branch-heads/4280@{#1432}
OS Ubuntu 18.04 LTS
Tor 1.0.12
Brave 1.17.71 Chromium: 87.0.4280.66 (Official Build) (64-bit)
Revision fd98a29dd59b36f71e4741332c9ad5bda42094bf-refs/branch-heads/4280@{#1432}
OS Ubuntu 18.04 LTS
Tor 1.0.15

cc @brave/legacy_qa @jumde @diracdeltas
@diracdeltas diracdeltas added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 19, 2020
@btlechowski
Copy link
Author

Probably fixed by brave/brave-core#7069
I was not able to reproduce on

Brave 1.19.22 Chromium: 87.0.4280.66 (Official Build) nightly (64-bit)
Revision fd98a29dd59b36f71e4741332c9ad5bda42094bf-refs/branch-heads/4280@{#1432}
OS Ubuntu 18.04 LTS

Added it to 1.19.x milestone so it can be retested.

@btlechowski btlechowski added this to the 1.19.x - Nightly milestone Nov 19, 2020
@LaurenWags
Copy link
Member

Could not reproduce with below build and Tor dev component 1.0.15:

Brave | 1.19.24 Chromium: 87.0.4280.67 (Official Build) nightly (x86_64)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | macOS Version 10.14.6 (Build 18G6042)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 11, 2020 •
edited by btlechowski
Loading

Verification passed on


Brave | 1.19.55 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.630)
  • Verified the STR from the description

Verification passed on

Brave 1.19.66 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor intermittent-issue OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.19.x - Release
Development

No branches or pull requests
4 participants
@diracdeltas @LaurenWags @btlechowski @GeetaSarvadnya