Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #10488 - Maximum ads received per hour settings are not respected #12718

Closed
GeetaSarvadnya opened this issue Nov 16, 2020 · 1 comment

Comments

@GeetaSarvadnya
Copy link

Description

Follow up of #10488 - Maximum ads received per hour settings are not respected

Steps to Reproduce

  1. Clean profile 1.17.68
  2. Enable rewards
  3. Open an NTP SI
  4. View an AD
  5. Regular ad is shown ( not NTP SI ad)
  6. Go to the tab opened in step 3 and click on the refresh icon in the URL bar and open New SI
  7. View and AD ( NTP SI ad is shown)
  8. Repeat step 6 for three times all the three times NTP SI ad is shown
  9. Open ad settings panel, default ads sets per hour is only 2 but users are able to see more than 2 ads.

Actual result:

Maximum ads received per hour settings are not respected
image

Expected result:

Maximum ads received per hour settings should be respected

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.17.68 Chromium: 87.0.4280.49 (Official Build) (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Windows 10 OS Version 1903 (Build 18362.1139)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Not sure
  • Can you reproduce this issue with the nightly channel? Not sure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @tmancey @jsecretan @rebron

@GeetaSarvadnya
Copy link
Author

Discussed with @tmancey confirmed working as expected hence closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant