Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] "Open in Tor" button needs minor UI polish when window is not in focus #12610

Open
LaurenWags opened this issue Nov 10, 2020 · 6 comments
Labels
feature/user-interface All UI related OS/Desktop OS/macOS polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Nov 10, 2020

Description

Found while testing #806

If you visit a site like brave.com in a normal window the Open in Tor button is shown in the URL bar. If you click elsewhere so the window is not in focus, the text on the button goes gray but the window icon to the right stays white. It looks a little odd. It is similar to this report of the bookmark icon not being dimmed when window is not in focus #11682

Steps to Reproduce

  1. Navigate to brave.com in a normal window
  2. Click elsewhere so the window is not in focus

Actual result:

Open in Tor text is gray, window icon to the right is white
Screen Shot 2020-11-10 at 10 48 23 AM

Expected result:

Text and icon colors to be the same when window is not in focus

for reference, this is what it looks like when the window is in focus:
Screen Shot 2020-11-10 at 10 48 32 AM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.17.65 Chromium: 87.0.4280.49 (Official Build) unknown (x86_64)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS macOS Version 10.14.6 (Build 18G6032)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a 1.16.x
  • Can you reproduce this issue with the beta channel? yes 1.17.x
  • Can you reproduce this issue with the nightly channel? yes 1.18.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron

@LaurenWags LaurenWags added polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude OS/Desktop labels Nov 10, 2020
@LaurenWags
Copy link
Member Author

also occurs on the Tor window with the "Onion Available" button in URL bar:
Screen Shot 2020-11-10 at 2 18 24 PM

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Nov 16, 2020
@rebron
Copy link
Collaborator

rebron commented Nov 16, 2020

Might be how we want it to look in the unfocused state though. cc: @karenkliu This is the Tor button faded in an unfocused state with the expected behavior (?) to remain bright even in unfocused state.

@karenkliu
Copy link

@rebron I think this is a valid issue. The unfocused state should give the Tor button the same treatment as the toolbar, and right now the dark grey seems a little out of place since it's not doing what everything else is doing. Let's keep the text #FFFFFF but have it at 40% opacity when window is not in focus.

@stephendonner
Copy link

cc @fallaciousreasoning @petemill

@GeetaSarvadnya
Copy link

Looks like macOS specific issue, Not reproducible on Windows 10 x64

@stephendonner stephendonner added the feature/user-interface All UI related label May 11, 2023
@fallaciousreasoning
Copy link

Doesn't reproduce on Linux either

@rebron rebron moved this to P5 backlog in Front End May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/user-interface All UI related OS/Desktop OS/macOS polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes release-notes/exclude
Projects
Status: P5 backlog
Development

No branches or pull requests

6 participants