Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CW] Certain sign type data doesn't show confirmation #11941

Closed
srirambv opened this issue Oct 1, 2020 · 2 comments
Closed

[CW] Certain sign type data doesn't show confirmation #11941

srirambv opened this issue Oct 1, 2020 · 2 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 1, 2020

Description

Certain sign type data doesn't show confirmation

Steps to Reproduce

  1. Install release component
  2. Visit https://danfinlay.github.io/js-eth-personal-sign-examples/ and connect wallet
  3. Try Sign Type Data and Sign Type Data 4, no confirmation shown
    (Tester's note: For Sign Type Data 4, you must be on the mainnet network)

Actual result:

cw-actual

Expected result:

cw-expected

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.14.84 Chromium: 85.0.4183.121 (Official Build) (64-bit)
Revision a81aa729a8e1fd413943a339393c82e7b8055ddc-refs/branch-heads/4183@{#1864}
OS Linux
Component 1.0.22

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Regression of #11367

@srirambv
Copy link
Contributor Author

Closing the issue as it seems to be fixed when testing from source build. Will test it against 0.1.79

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.15.75 Chromium: 86.0.4240.99 (Official Build) (64-bit)
Revision 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS Linux
Component 0.1.79 / 1.0.15 dev component
  • Verified confirmation is shown for all signed types
    sign-linux

Verification passed on

Brave 1.16.62 Chromium: 86.0.4240.80 (Official Build) (64-bit)
Revision 7ed88b53bda45a2d19efb4f8706dd6b6cad0d3af-refs/branch-heads/4240@{#1183}
OS Windows 10 OS Version 1809 (Build 17763.518)
Component 0.1.79 / 1.0.15 dev component
  • Verified confirmation is shown for all signed types
    sign-win

Verification passed on

Brave 1.17.43 Chromium: 86.0.4240.99 (Official Build) nightly (x86_64)
Revision 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS macOS Version 10.15.7 (Build 19H2)
Component 0.1.79 / 1.0.15 dev component
  • Verified confirmation is shown for all signed types
    sign-mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment