-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Twitter Greaselion script to use locales directory for localizations #11890
Comments
@emerick since this one is marked |
@LaurenWags I updated the test plan in the PR, give me a holler if anything doesn't make sense with it. |
Verified passed with
Verified test plan from brave/brave-core#6683. Note - each OS may have a slightly different method to getting Brave to display in a different language (as noted in the steps). Here are the steps I followed - modified from the PR after discussion with @emerick:
Verification passed on
Verified test plan from brave/brave-core#6683. Verification passed on
Verified test plan from brave/brave-core#6683. US locale: |
When brave/brave-core#6683 is merged, update our Twitter Greaselion script to use the
locales_
directory for localizations. Currently, the text for our UI is hardcoded directly into the Twitter script.The text was updated successfully, but these errors were encountered: