Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards panel doesn't show creator specific information for Vimeo #11840

Closed
LaurenWags opened this issue Sep 24, 2020 · 2 comments
Closed

Rewards panel doesn't show creator specific information for Vimeo #11840

LaurenWags opened this issue Sep 24, 2020 · 2 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Sep 24, 2020

Description

Rewards panel does not show creator specific information for vimeo publishers. Subsequently, you are unable to tip specific Vimeo publishers as well.

This doesn't work on older versions where it used to (ex. 1.12.x as per #9502 (comment)) so it is likely there was a change on Vimeo's side.

Steps to Reproduce

  1. Clean profile
  2. Enable Rewards, wait for publisher list indexes to be downloaded
  3. Visit a vimeo page (ex. vimeo.com/bravelaurenwags on staging)

Actual result:

Vimeo publisher info is not shown in panel. Note, viewing the video from this page still seems to add the publisher to the AC list.
Screen Shot 2020-09-24 at 11 41 11 AM

In the above, it should say "Lauren on Vimeo" (or similar)
Additionally, choosing one of the tip buttons does not bring up the publisher's banner, but shows the generic banner for a non-verified publisher.

Expected result:

Vimeo publisher info should be shown in the panel.

Reproduces how often:

easily

Brave version (brave://version info)

1.12.x, 1.13.x, 1.14.x, 1.15.x, 1.16.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc @brave/legacy_qa

@emerick
Copy link
Contributor

emerick commented Nov 7, 2020

Fixed by brave/brave-core#6955

@LaurenWags
Copy link
Member Author

LaurenWags commented Nov 25, 2020

Verified passed with

Brave | 1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | macOS Version 10.14.6 (Build 18G6042)

Confirmed panel showed expected creator information for user and video URLs on Vimeo.

Testing was completed as part of #11465 and testing notes can be found under #11465 (comment)


Verification passed on


Brave | 1.18.65 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)


Confirmed panel showed expected creator information for user and video URLs on Vimeo.

Testing was completed as part of #11465 and testing notes can be found under #11465 (comment)

@rebron rebron changed the title [Desktop] rewards panel doesn't show creator specific information for Vimeo Rewards panel doesn't show creator specific information for Vimeo Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment