Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support automatic redirection of IPFS gateway resources #11564

Closed
bbondy opened this issue Sep 2, 2020 · 1 comment · Fixed by brave/brave-core#7299
Closed

Support automatic redirection of IPFS gateway resources #11564

bbondy opened this issue Sep 2, 2020 · 1 comment · Fixed by brave/brave-core#7299
Assignees
@bbondy
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.20.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Sep 2, 2020 •
edited
Loading

When a gateway URL is detected, redirect it to the local node instead .
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude OS/Desktop labels Sep 2, 2020
@bbondy bbondy changed the title Add setting to support automatic redirection of IPFS gateway resources Support automatic redirection of IPFS gateway resources Sep 4, 2020
@bbondy bbondy self-assigned this Sep 4, 2020
@srirambv srirambv changed the title Support automatic redirection of IPFS gateway resources [Desktop] Support automatic redirection of IPFS gateway resources Sep 9, 2020
@bbondy bbondy changed the title [Desktop] Support automatic redirection of IPFS gateway resources Support automatic redirection of IPFS gateway resources Sep 22, 2020
@bbondy bbondy assigned bbondy and unassigned bbondy Oct 28, 2020
@bbondy bbondy mentioned this issue Dec 11, 2020
Merged
23 tasks
@bbondy bbondy added this to the 1.20.x - Nightly milestone Dec 13, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jan 22, 2021 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave	1.20.87 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	macOS Version 10.15.7 (Build 19H15)

Verified test plan from brave/brave-core#7299

Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ and confirmed link loaded without any redirect 1
Enabled "Redirect IPFS resources to the configured IPFS gateway" setting in brave://settings/extensions 2
Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ in a new tab and confirmed link loaded with redirect to configured gateway 3 4
Modified "IPFS public gateway address" setting in brave://settings/extensions 5 6
Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ in a new tab and confirmed link loaded with redirect to the changed gateway 8
Installed IPFS from infobar. Confirmed "Method to resolve IPFS resources" was set to Local node in brave://settings/extensions

Note - had to refresh page due to #13171.

9
Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ in a new tab and confirmed link loaded with local node 11

Verification passed on

Brave 1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#7299

Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ and confirmed link loaded without any redirect

image

Enabled "Redirect IPFS resources to the configured IPFS gateway" setting in brave://settings/extensions

image

Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ in a new tab and confirmed link loaded with redirect to configured gateway ![image](https://user-images.githubusercontent.com/34715963/105781447-e6eaf380-5f72-11eb-843a-0d613cd9c214.png)
Modified "IPFS public gateway address" setting in brave://settings/extensions

image

Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ in a new tab and confirmed link loaded with redirect to the changed gateway

image

Installed IPFS from infobar. Confirmed "Method to resolve IPFS resources" was set to Local node in brave://settings/extensions

Note - had to refresh page due to #13171.

image

Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ in a new tab and confirmed link loaded with local node

image

Verification passed on


Brave | 1.20.93 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified test plan from brave/brave-core#7299

Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ and confirmed link loaded without any redirect

image

Enabled "Redirect IPFS resources to the configured IPFS gateway" setting in brave://settings/extensions

image

Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ in a new tab and confirmed link loaded with redirect to configured gateway

image
image

Modified "IPFS public gateway address" setting in brave://settings/extensions

image
image

Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ in a new tab and confirmed link loaded with redirect to the changed gateway ![image](https://user-images.githubusercontent.com/38657976/106437459-509b5e00-649b-11eb-95e0-201c9abc893b.png)
Installed IPFS from infobar. Confirmed "Method to resolve IPFS resources" was set to Local node in brave://settings/extensions

image

Navigated to https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/ in a new tab and confirmed link loaded with local node ![image](https://user-images.githubusercontent.com/38657976/106438636-c05e1880-649c-11eb-976c-3626f21cfaa3.png)

@LaurenWags LaurenWags mentioned this issue Feb 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging a pull request may close this issue.

Automatically redirect gateway resources brave/brave-core
4 participants
@bbondy @LaurenWags @btlechowski @GeetaSarvadnya