Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show gateway URL instead of masking as ipfs:// when using a gateway #11561

Closed
bbondy opened this issue Sep 2, 2020 · 0 comments · Fixed by brave/brave-core#6676
Closed

Show gateway URL instead of masking as ipfs:// when using a gateway #11561

bbondy opened this issue Sep 2, 2020 · 0 comments · Fixed by brave/brave-core#6676
Assignees
@bbondy
Labels
feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.16.x - Release #1

Comments

@bbondy
Copy link
Member

bbondy commented Sep 2, 2020

Subset of: #10220

Currently the user can't tell that a gateway is being used when they navigate to an IPFS URL.
We should show the gateway URL at all times unless it is the local node configured in Brave. In that case, we can show ipfs://
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/ipfs OS/Desktop labels Sep 2, 2020
@bbondy bbondy self-assigned this Sep 2, 2020
@srirambv srirambv changed the title Show gateway URL instead of masking as ipfs:// when using a gateway [Desktop] Show gateway URL instead of masking as ipfs:// when using a gateway Sep 9, 2020
@bbondy bbondy changed the title [Desktop] Show gateway URL instead of masking as ipfs:// when using a gateway Show gateway URL instead of masking as ipfs:// when using a gateway Sep 21, 2020
@bbondy bbondy mentioned this issue Sep 21, 2020
Merged
32 tasks
@bbondy bbondy added this to the 1.16.x - Nightly milestone Sep 25, 2020
@bbondy bbondy added QA/No and removed QA/Yes labels Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.16.x - Release #1
Development

Successfully merging a pull request may close this issue.

Show gateway URL instead of masking as ipfs scheme for gateway brave/brave-core
1 participant
@bbondy