Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next payment date is changed to an incorrect date after rewards reset #11478

Closed
GeetaSarvadnya opened this issue Aug 27, 2020 · 4 comments
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 27, 2020

Description

Next payment date is changed to an incorrect date after rewards reset

Steps to Reproduce

  1. Clean profile 1.13.x
  2. Enable rewards
  3. Ensure that Next payment date is displayed as Sep 6
  4. Reset Rewards via brave://rewards Gear icon
  5. Opt into rewards again by clicking on YES, I'M IN!
  6. Next payment date changed to Oct 6

Actual result:

Next payment date is changed to an incorrect date after rewards reset

Rewards reset makes next payment date change

Before rewards reset:
image

After rewards reset:
image

Expected result:

Next payment date should not change after rewards reset

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.13.82 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Windows 10 OS Version 1903 (Build 18362.1016)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @tmancey @rebron

@rebron
Copy link
Collaborator

rebron commented Oct 9, 2020

cc: @jsecretan Can you help with prioritizing this one? I remember there's other related work around this.

@tmancey
Copy link
Contributor

tmancey commented Oct 9, 2020

@jsecretan moved to icebox as date is correctly shown once an ad has been viewed

@tmancey tmancey changed the title [Desktop] Next payment date is changed to an incorrect date after rewards reset Next payment date is changed to an incorrect date after rewards reset Dec 5, 2020
@tmancey tmancey added the QA/Yes label Dec 5, 2020
@tmancey tmancey added this to the 1.20.x - Nightly milestone Dec 5, 2020
@tmancey tmancey self-assigned this Dec 5, 2020
@tmancey tmancey added release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 5, 2020
@tmancey
Copy link
Contributor

tmancey commented Dec 5, 2020

@GeetaSarvadnya Unable to reproduce, can you please retest on 1.20.x

@tmancey tmancey closed this as completed Dec 5, 2020
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jan 20, 2021

Verification passed on


Brave | 1.20.84 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)


Verified passed with

Brave | 1.20.84 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | macOS Version 10.15.7 (Build 19H15)

Verified STR from description. Confirmed Next payment date was displayed as expected after each reset.


Verification passed on

Brave 1.20.86 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

Verified STR from description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants