Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Purchase Intent parent only segments should not block page classification parent segment Brave ads #11410

Closed
tmancey opened this issue Aug 24, 2020 · 3 comments · Fixed by brave/brave-core#6483
Closed

[Desktop] Purchase Intent parent only segments should not block page classification parent segment Brave ads #11410

tmancey opened this issue Aug 24, 2020 · 3 comments · Fixed by brave/brave-core#6483
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.14.x - Release #1

Comments

@tmancey
Copy link
Contributor

tmancey commented Aug 24, 2020

Description

Purchase Intent parent only segments should not block page classification parent segment Brave ads

Steps to Reproduce

  1. Trigger purchase intent for a parent only segment
  2. Wait for an attempt to deliver an ad (check logs)

Actual result:

Parent category Brave ads are blocked if a purchase intent was extracted with a parent only segment

Expected result:

Parent category Brave ads should not be blocked if a purchase intent was extracted with a parent only segment

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:
@tmancey tmancey added bug priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/ads OS/Desktop labels Aug 24, 2020
@tmancey tmancey self-assigned this Aug 24, 2020
@tmancey tmancey mentioned this issue Aug 24, 2020
Merged
32 tasks
@tmancey tmancey added this to the 1.15.x - Nightly milestone Aug 26, 2020
@tmancey tmancey mentioned this issue Aug 26, 2020
Merged
4 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Sep 3, 2020

@tmancey does this affect Android or just specific to Desktop?

@tmancey
Copy link
Contributor Author

tmancey commented Sep 3, 2020

@kjozwiak Core business logic change so only needs testing on desktop. I have previously gone through all open issues for ads and labeled with Android where needed. Thanks

@btlechowski btlechowski modified the milestone: 1.14.x - Release Sep 8, 2020
@btlechowski
Copy link

btlechowski commented Sep 8, 2020 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.14.79 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

Used test plan from https://github.com/brave/internal/issues/717 and the test plan from brave/brave-core#6483

Verified Parent segment derived from parent only purchase intent

[12495:12495:0910/223946.176457:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[12495:12495:0910/223946.176547:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[12495:12495:0910/223946.176634:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[12495:12495:0910/223946.176699:VERBOSE1:ads_impl.cc(752)]   gamer
[12495:12495:0910/223946.178301:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[12495:12495:0910/223946.178401:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[12495:12495:0910/223946.178470:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[12495:12495:0910/223946.179151:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 161d1742-a063-4e8d-825f-3bc39e06e9c0
  parentUuid: 838bebed-5fb2-4ea4-9274-33cf0cb77bf1
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer
  title: gamer
  body: gamer

Verified Parent-child segment derived from parent-child purchase intent

[13170:13170:0910/224821.339197:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[13170:13170:0910/224821.339359:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[13170:13170:0910/224821.339488:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[13170:13170:0910/224821.339566:VERBOSE1:ads_impl.cc(752)]   gamer-alpha influencers
[13170:13170:0910/224821.341437:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[13170:13170:0910/224821.341539:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[13170:13170:0910/224821.341610:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[13170:13170:0910/224821.342253:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 72a34032-14b0-4801-a60c-d9522c5bbfce
  parentUuid: f95f2eb4-8666-4973-a43f-1ab8b5ffa9d6
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer-mainstream enthusiasts
  title: gamer-mainstream enthusiasts
  body: gamer-mainstream enthusiasts
  targetUrl: https://brave.com

Verified Parent segment derived from parent-child purchase intent

[13710:13710:0910/225605.307694:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[13710:13710:0910/225605.307789:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[13710:13710:0910/225605.307874:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[13710:13710:0910/225605.307931:VERBOSE1:ads_impl.cc(752)]   gamer-alpha influencers
[13710:13710:0910/225605.308839:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[13710:13710:0910/225605.308942:VERBOSE1:ads_impl.cc(770)]   gamer-pc purists
[13710:13710:0910/225605.309000:VERBOSE1:ads_impl.cc(770)]   gamer-mainstream enthusiasts
[13710:13710:0910/225605.309071:VERBOSE1:ads_impl.cc(770)]   gamer-alpha influencers
[13710:13710:0910/225605.309169:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[13710:13710:0910/225605.309239:VERBOSE1:ads_impl.cc(788)]   gamer
[13710:13710:0910/225605.311557:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[13710:13710:0910/225605.311674:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[13710:13710:0910/225605.311735:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[13710:13710:0910/225605.311963:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 0d5bec78-e33c-49ca-8b6e-ff72dc642f52
  parentUuid: 04647fc8-b460-48ef-8b32-dc7e76460a28
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer
  title: gamer
  body: gamer
  targetUrl: https://brave.com

Verified Show other ad after parent only purchase intent ad

829:14829:0910/234225.348603:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[14829:14829:0910/234225.348869:VERBOSE1:ads_impl.cc(752)]   technology & computing-software
[14829:14829:0910/234225.349119:VERBOSE1:ads_impl.cc(752)]   personal finance-personal finance
[14829:14829:0910/234225.349309:VERBOSE1:ads_impl.cc(752)]   food & drink-vegetarian
[14829:14829:0910/234225.349555:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[14829:14829:0910/234225.349741:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[14829:14829:0910/234225.350012:VERBOSE1:ads_impl.cc(752)]   gamer
[14829:14829:0910/234225.352182:VERBOSE1:ads_impl.cc(985)] All advertisers have been shown, so round robin
[14829:14829:0910/234225.359654:VERBOSE1:client.cc(392)] Resetting seen advertisers
[14829:14829:0910/234225.360574:VERBOSE1:ads_impl.cc(1009)] All ads have been shown, so round robin
[14829:14829:0910/234225.360793:VERBOSE1:client.cc(365)] Resetting seen ad notifications
[14829:14829:0910/234225.362184:VERBOSE2:ads_impl.cc(970)] creativeInstanceId 6a66e391-9a1d-4349-8a04-64751edf692b has exceeded the frequency capping for perHour
[14829:14829:0910/234225.362370:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[14829:14829:0910/234225.362535:VERBOSE1:ads_impl.cc(770)]   technology & computing-software
[14829:14829:0910/234225.362657:VERBOSE1:ads_impl.cc(770)]   personal finance-personal finance
[14829:14829:0910/234225.362755:VERBOSE1:ads_impl.cc(770)]   food & drink-vegetarian
[14829:14829:0910/234225.362856:VERBOSE1:ads_impl.cc(770)]   gamer-pc purists
[14829:14829:0910/234225.362965:VERBOSE1:ads_impl.cc(770)]   gamer-mainstream enthusiasts
[14829:14829:0910/234225.363070:VERBOSE1:ads_impl.cc(770)]   gamer
[14829:14829:0910/234225.363150:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[14829:14829:0910/234225.364453:VERBOSE1:ads_impl.cc(788)]   technology & computing
[14829:14829:0910/234225.364557:VERBOSE1:ads_impl.cc(788)]   personal finance
[14829:14829:0910/234225.364668:VERBOSE1:ads_impl.cc(788)]   food & drink
[14829:14829:0910/234225.364751:VERBOSE1:ads_impl.cc(788)]   gamer
[14829:14829:0910/234225.377782:VERBOSE2:ads_impl.cc(970)] creativeInstanceId 6a66e391-9a1d-4349-8a04-64751edf692b has exceeded the frequency capping for perHour
[14829:14829:0910/234225.377830:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[14829:14829:0910/234225.377868:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[14829:14829:0910/234225.377890:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[14829:14829:0910/234225.382712:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: df14d93f-068a-4925-9e99-12835f4c9a9d
  parentUuid: 1fc40cd4-98de-4307-9c74-5a6fd356e272
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: technology & computing
  title: Technology & Computing
  body: Technology & Computing
  targetUrl: https://brave.com/purchase-intent-test

Verified Show other ad after parent-child purchase intent ad

[15534:15534:0910/234239.659652:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[15534:15534:0910/234239.659698:VERBOSE1:ads_impl.cc(752)]   technology & computing-software
[15534:15534:0910/234239.659736:VERBOSE1:ads_impl.cc(752)]   personal finance-personal finance
[15534:15534:0910/234239.659753:VERBOSE1:ads_impl.cc(752)]   food & drink-vegetarian
[15534:15534:0910/234239.659783:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[15534:15534:0910/234239.659804:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[15534:15534:0910/234239.659833:VERBOSE1:ads_impl.cc(752)]   gamer-alpha influencers
[15534:15534:0910/234239.661104:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[15534:15534:0910/234239.661144:VERBOSE1:ads_impl.cc(770)]   technology & computing-software
[15534:15534:0910/234239.661179:VERBOSE1:ads_impl.cc(770)]   personal finance-personal finance
[15534:15534:0910/234239.661196:VERBOSE1:ads_impl.cc(770)]   food & drink-vegetarian
[15534:15534:0910/234239.661226:VERBOSE1:ads_impl.cc(770)]   gamer-pc purists
[15534:15534:0910/234239.661244:VERBOSE1:ads_impl.cc(770)]   gamer-mainstream enthusiasts
[15534:15534:0910/234239.661274:VERBOSE1:ads_impl.cc(770)]   gamer-alpha influencers
[15534:15534:0910/234239.661291:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[15534:15534:0910/234239.661320:VERBOSE1:ads_impl.cc(788)]   technology & computing
[15534:15534:0910/234239.661341:VERBOSE1:ads_impl.cc(788)]   personal finance
[15534:15534:0910/234239.661376:VERBOSE1:ads_impl.cc(788)]   food & drink
[15534:15534:0910/234239.661393:VERBOSE1:ads_impl.cc(788)]   gamer
[15534:15534:0910/234239.664115:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[15534:15534:0910/234239.664160:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[15534:15534:0910/234239.664200:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[15534:15534:0910/234239.664388:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: b417acd4-86a6-4820-a696-dcaf284c553b
  parentUuid: fc6f8692-1090-48d5-b922-cbab9ccf7bf2
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: technology & computing
  title: Technology & Computing
  body: Technology & Computing
  targetUrl: https://brave.com/purchase-intent-test

Verified visiting www.cnet.com and confirmed intent signals are added to purchaseIntentSignalHistory

"purchaseIntentSignalHistory":{"gamer-alpha influencers":[{"timestamp_in_seconds":1599774275,"weight":1}]}

Verified searching for amd in Google and confirm intent signals are added to purchaseIntentSignalHistory

"purchaseIntentSignalHistory":{"gamer":[{"timestamp_in_seconds":1599770267,"weight":1},{"timestamp_in_seconds":1599770268,"weight":1}],"gamer-mainstream enthusiasts":[{"timestamp_in_seconds":1599770267,"weight":1},{"timestamp_in_seconds":1599770268,"weight":1}],"gamer-pc purists":[{"timestamp_in_seconds":1599770267,"weight":1},{"timestamp_in_seconds":1599770268,"weight":1}]}

Verification passed on

Brave | 1.14.80 Chromium: 85.0.4183.102 (Official Build) (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Verified Parent segment derived from the parent only purchase intent

[2008:20032:0911/204021.720:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[2008:20032:0911/204021.720:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[2008:20032:0911/204021.723:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[2008:20032:0911/204021.723:VERBOSE1:ads_impl.cc(752)]   gamer-alpha influencers
[2008:20032:0911/204021.724:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[2008:20032:0911/204021.732:VERBOSE1:ads_impl.cc(770)]   gamer-pc purists
[2008:20032:0911/204021.733:VERBOSE1:ads_impl.cc(770)]   gamer-mainstream enthusiasts
[2008:20032:0911/204021.735:VERBOSE1:ads_impl.cc(770)]   gamer-alpha influencers
[2008:20032:0911/204021.736:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[2008:20032:0911/204021.744:VERBOSE1:ads_impl.cc(788)]   gamer
[2008:20032:0911/204021.747:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[2008:20032:0911/204021.748:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[2008:20032:0911/204021.748:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[2008:20032:0911/204021.754:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: c847dc29-ee80-4f6c-b8f3-3f0d94dc96af
  parentUuid: 8b75103e-a088-4e4b-bd4f-1c4315cd4107
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer
  title: gamer
  body: gamer

Verified Parent-child segment derived from parent-child purchase intent

[13272:12320:0911/230453.471:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[13272:12320:0911/230453.471:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[13272:12320:0911/230453.474:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[13272:12320:0911/230453.482:VERBOSE1:ads_impl.cc(752)]   gamer-alpha influencers
[13272:12320:0911/230453.485:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[13272:12320:0911/230453.485:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[13272:12320:0911/230453.491:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[13272:12320:0911/230453.492:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: becfd872-e985-41d7-85ae-468bbee60b70
  parentUuid: a2426c24-43d9-4854-9d34-64e85d7cabc2
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer-mainstream enthusiasts
  title: gamer-mainstream enthusiasts
  body: gamer-mainstream enthusiasts
  targetUrl: https://brave.com

Verified Parent segment derived from parent-child purchase intent

[20388:7648:0911/231918.228:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[20388:7648:0911/231918.229:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[20388:7648:0911/231918.229:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[20388:7648:0911/231918.236:VERBOSE1:ads_impl.cc(752)]   gamer-alpha influencers
[20388:7648:0911/231918.239:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[20388:7648:0911/231918.240:VERBOSE1:ads_impl.cc(770)]   gamer-pc purists
[20388:7648:0911/231918.246:VERBOSE1:ads_impl.cc(770)]   gamer-mainstream enthusiasts
[20388:7648:0911/231918.246:VERBOSE1:ads_impl.cc(770)]   gamer-alpha influencers
[20388:7648:0911/231918.249:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[20388:7648:0911/231918.249:VERBOSE1:ads_impl.cc(788)]   gamer
[20388:7648:0911/231918.258:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[20388:7648:0911/231918.258:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[20388:7648:0911/231918.258:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[20388:7648:0911/231918.266:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 7526ebed-9832-4acb-833d-d38655981960
  parentUuid: e037bc83-6ecc-4ad1-ab84-f0e76017cdc5
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer
  title: gamer
  body: gamer
  targetUrl: https://brave.com

Verified Show other ad after parent only purchase intent ad

[18812:12040:0914/231159.027:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[18812:12040:0914/231159.027:VERBOSE1:ads_impl.cc(752)]   technology & computing-software
[18812:12040:0914/231159.028:VERBOSE1:ads_impl.cc(752)]   personal finance-personal finance
[18812:12040:0914/231159.028:VERBOSE1:ads_impl.cc(752)]   food & drink-vegetarian
[18812:12040:0914/231159.031:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[18812:12040:0914/231159.031:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[18812:12040:0914/231159.032:VERBOSE1:ads_impl.cc(752)]   gamer
[18812:12040:0914/231159.033:VERBOSE1:ads_impl.cc(985)] All advertisers have been shown, so round robin
[18812:12040:0914/231159.033:VERBOSE1:client.cc(392)] Resetting seen advertisers
[18812:12040:0914/231159.034:VERBOSE1:ads_impl.cc(1009)] All ads have been shown, so round robin
[18812:12040:0914/231159.034:VERBOSE1:client.cc(365)] Resetting seen ad notifications
[18812:12040:0914/231159.036:VERBOSE2:ads_impl.cc(970)] creativeInstanceId 6a66e391-9a1d-4349-8a04-64751edf692b has exceeded the frequency capping for perHour
[18812:12040:0914/231159.048:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[18812:12040:0914/231159.048:VERBOSE1:ads_impl.cc(770)]   technology & computing-software
[18812:12040:0914/231159.060:VERBOSE1:ads_impl.cc(770)]   personal finance-personal finance
[18812:12040:0914/231159.064:VERBOSE1:ads_impl.cc(770)]   food & drink-vegetarian
[18812:12040:0914/231159.072:VERBOSE1:ads_impl.cc(770)]   gamer-pc purists
[18812:12040:0914/231159.077:VERBOSE1:ads_impl.cc(770)]   gamer-mainstream enthusiasts
[18812:12040:0914/231159.077:VERBOSE1:ads_impl.cc(770)]   gamer
[18812:12040:0914/231159.085:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[18812:12040:0914/231159.087:VERBOSE1:ads_impl.cc(788)]   technology & computing
[18812:12040:0914/231159.087:VERBOSE1:ads_impl.cc(788)]   personal finance
[18812:12040:0914/231159.096:VERBOSE1:ads_impl.cc(788)]   food & drink
[18812:12040:0914/231159.098:VERBOSE1:ads_impl.cc(788)]   gamer
[18812:12040:0914/231159.101:VERBOSE2:ads_impl.cc(970)] creativeInstanceId 6a66e391-9a1d-4349-8a04-64751edf692b has exceeded the frequency capping for perHour
[18812:12040:0914/231159.106:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[18812:12040:0914/231159.109:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[18812:12040:0914/231159.110:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[18812:12040:0914/231159.119:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 67944cbf-ad8f-47fd-a6d8-529e968c8814
  parentUuid: 0a0d645d-6d74-48c9-89b6-d37df2d1af10
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: technology & computing
  title: Technology & Computing
  body: Technology & Computing
  targetUrl: https://brave.com/purchase-intent-test

Verified Show other ad after parent-child purchase intent ad

[13040:2636:0911/004506.377:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[13040:2636:0911/004506.377:VERBOSE1:ads_impl.cc(752)]   technology & computing-software
[13040:2636:0911/004506.378:VERBOSE1:ads_impl.cc(752)]   personal finance-personal finance
[13040:2636:0911/004506.379:VERBOSE1:ads_impl.cc(752)]   food & drink-vegetarian
[13040:2636:0911/004506.380:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[13040:2636:0911/004506.380:VERBOSE1:ads_impl.cc(770)]   technology & computing-software
[13040:2636:0911/004506.381:VERBOSE1:ads_impl.cc(770)]   personal finance-personal finance
[13040:2636:0911/004506.382:VERBOSE1:ads_impl.cc(770)]   food & drink-vegetarian
[13040:2636:0911/004506.393:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[13040:2636:0911/004506.393:VERBOSE1:ads_impl.cc(788)]   technology & computing
[13040:2636:0911/004506.395:VERBOSE1:ads_impl.cc(788)]   personal finance
[13040:2636:0911/004506.395:VERBOSE1:ads_impl.cc(788)]   food & drink
[13040:2636:0911/004506.397:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[13040:2636:0911/004506.397:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[13040:2636:0911/004506.397:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[13040:2636:0911/004506.398:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 951c2b61-b00e-4b89-b803-925777577335
  parentUuid: e63e62e7-2e49-476f-b32d-947fad6698bd
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: technology & computing
  title: Technology & Computing
  body: Technology & Computing
  targetUrl: https://brave.com/purchase-intent-test
[13040:2636:0911/004506.404:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid 951c2b61-b00e-4b89-b803-925777577335 and d9dc0028-8f86-4c92-b25d-981bc1bdb903 creative instance id
[13040:2636:0911/004506.413:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: technology & computing
  targetUrl: https://brave.com/purchase-intent-test

Verified visiting www.cnet.com and confirmed intent signals are added to purchaseIntentSignalHistory

"purchaseIntentSignalHistory": {
    "gamer-alpha influencers": [
      {
        "timestamp_in_seconds": 1599765866,
        "weight": 1
      }
    ]
  },

Verified searching for amd in Google and confirm intent signals are added to purchaseIntentSignalHistory

 "purchaseIntentSignalHistory": {
    "gamer-alpha influencers": [
      {
        "timestamp_in_seconds": 1599766063,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1599766063,
        "weight": 1
      }
    ],
    "gamer-mainstream enthusiasts": [
      {
        "timestamp_in_seconds": 1599766063,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1599766063,
        "weight": 1
      }
    ],
    "gamer-pc purists": [
      {
        "timestamp_in_seconds": 1599766063,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1599766063,
        "weight": 1
      }
    ]
  },

Verified passed with

Brave	1.14.80 Chromium: 85.0.4183.102 (Official Build) (64-bit)
Revision	ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS	macOS Version 10.14.6 (Build 18G3020)

Used test plan from https://github.com/brave/internal/issues/717 and the test plan from brave/brave-core#6483

Parent segment derived from parent only purchase intent

[6739:775:0911/125329.340819:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[6739:775:0911/125329.340880:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[6739:775:0911/125329.340920:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[6739:775:0911/125329.340954:VERBOSE1:ads_impl.cc(752)]   gamer
[6739:775:0911/125329.342412:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[6739:775:0911/125329.342475:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[6739:775:0911/125329.342515:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[6739:775:0911/125329.342700:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 9bddee2d-7b47-4830-9c5c-5cce71bcf7ec
  parentUuid: d7384c52-d4b6-4def-9403-41fe60af8ab8
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer
  title: gamer
  body: gamer
  targetUrl: https://brave.com
[6739:775:0911/125329.343296:VERBOSE1:ads_service_impl.cc(2034)] Timeout ad notification with uuid 9bddee2d-7b47-4830-9c5c-5cce71bcf7ec in 120 seconds
[6739:775:0911/125329.343522:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid 9bddee2d-7b47-4830-9c5c-5cce71bcf7ec and 6a66e391-9a1d-4349-8a04-64751edf692b creative instance id
[6739:775:0911/125329.343626:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer
  targetUrl: https://brave.com
  geoTarget: US
  confirmationType: view

Parent-child segment derived from parent-child purchase intent

[6764:775:0911/125644.090892:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[6764:775:0911/125644.090960:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[6764:775:0911/125644.090998:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[6764:775:0911/125644.091033:VERBOSE1:ads_impl.cc(752)]   gamer-alpha influencers
[6764:775:0911/125644.092626:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[6764:775:0911/125644.092698:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[6764:775:0911/125644.092746:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[6764:775:0911/125644.092930:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: b3715e29-a32f-4b95-81d7-8bcd1445d615
  parentUuid: 12d06539-1fa7-427a-a72a-ec9a9e121355
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer-mainstream enthusiasts
  title: gamer-mainstream enthusiasts
  body: gamer-mainstream enthusiasts
  targetUrl: https://brave.com
[6764:775:0911/125644.093536:VERBOSE1:ads_service_impl.cc(2034)] Timeout ad notification with uuid b3715e29-a32f-4b95-81d7-8bcd1445d615 in 120 seconds
[6764:775:0911/125644.093670:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid b3715e29-a32f-4b95-81d7-8bcd1445d615 and 6a66e391-9a1d-4349-8a04-64751edf692b creative instance id
[6764:775:0911/125644.093794:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer-mainstream enthusiasts
  targetUrl: https://brave.com
  geoTarget: US
  confirmationType: view

Parent segment derived from parent-child purchase intent

[6819:775:0911/130109.481958:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[6819:775:0911/130109.482033:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[6819:775:0911/130109.482076:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[6819:775:0911/130109.482111:VERBOSE1:ads_impl.cc(752)]   gamer-alpha influencers
[6819:775:0911/130109.483062:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[6819:775:0911/130109.483129:VERBOSE1:ads_impl.cc(770)]   gamer-pc purists
[6819:775:0911/130109.483167:VERBOSE1:ads_impl.cc(770)]   gamer-mainstream enthusiasts
[6819:775:0911/130109.483200:VERBOSE1:ads_impl.cc(770)]   gamer-alpha influencers
[6819:775:0911/130109.483233:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[6819:775:0911/130109.483264:VERBOSE1:ads_impl.cc(788)]   gamer
[6819:775:0911/130109.484723:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[6819:775:0911/130109.484794:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[6819:775:0911/130109.484837:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[6819:775:0911/130109.485012:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: 32907e74-94df-417c-96d9-2dcbfbb93f71
  parentUuid: 78d090f4-3a21-4c03-9ee5-7b29eb5674f8
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer
  title: gamer
  body: gamer
  targetUrl: https://brave.com
[6819:775:0911/130109.485605:VERBOSE1:ads_service_impl.cc(2034)] Timeout ad notification with uuid 32907e74-94df-417c-96d9-2dcbfbb93f71 in 120 seconds
[6819:775:0911/130109.485733:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid 32907e74-94df-417c-96d9-2dcbfbb93f71 and 6a66e391-9a1d-4349-8a04-64751edf692b creative instance id
[6819:775:0911/130109.485980:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: 6a66e391-9a1d-4349-8a04-64751edf692b
  creativeSetId: 0aa3505d-9829-4c34-911a-7e0ecb691483
  category: gamer
  targetUrl: https://brave.com
  geoTarget: US
  confirmationType: view

Show other ad after parent only purchase intent ad

[6893:775:0911/134316.940632:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[6893:775:0911/134316.940714:VERBOSE1:ads_impl.cc(752)]   technology & computing-software
[6893:775:0911/134316.940755:VERBOSE1:ads_impl.cc(752)]   personal finance-personal finance
[6893:775:0911/134316.940789:VERBOSE1:ads_impl.cc(752)]   food & drink-vegetarian
[6893:775:0911/134316.940822:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[6893:775:0911/134316.940854:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[6893:775:0911/134316.940887:VERBOSE1:ads_impl.cc(752)]   gamer
[6893:775:0911/134316.941594:VERBOSE1:ads_impl.cc(985)] All advertisers have been shown, so round robin
[6893:775:0911/134316.941667:VERBOSE1:client.cc(392)] Resetting seen advertisers
[6893:775:0911/134316.941753:VERBOSE1:ads_impl.cc(1009)] All ads have been shown, so round robin
[6893:775:0911/134316.941786:VERBOSE1:client.cc(365)] Resetting seen ad notifications
[6893:775:0911/134316.942835:VERBOSE2:ads_impl.cc(970)] creativeInstanceId 6a66e391-9a1d-4349-8a04-64751edf692b has exceeded the frequency capping for perHour
[6893:775:0911/134316.942903:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[6893:775:0911/134316.942941:VERBOSE1:ads_impl.cc(770)]   technology & computing-software
[6893:775:0911/134316.942972:VERBOSE1:ads_impl.cc(770)]   personal finance-personal finance
[6893:775:0911/134316.943002:VERBOSE1:ads_impl.cc(770)]   food & drink-vegetarian
[6893:775:0911/134316.943033:VERBOSE1:ads_impl.cc(770)]   gamer-pc purists
[6893:775:0911/134316.943063:VERBOSE1:ads_impl.cc(770)]   gamer-mainstream enthusiasts
[6893:775:0911/134316.943092:VERBOSE1:ads_impl.cc(770)]   gamer
[6893:775:0911/134316.943121:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[6893:775:0911/134316.943150:VERBOSE1:ads_impl.cc(788)]   technology & computing
[6893:775:0911/134316.943180:VERBOSE1:ads_impl.cc(788)]   personal finance
[6893:775:0911/134316.943209:VERBOSE1:ads_impl.cc(788)]   food & drink
[6893:775:0911/134316.943238:VERBOSE1:ads_impl.cc(788)]   gamer
[6893:775:0911/134316.969006:VERBOSE2:ads_impl.cc(970)] creativeInstanceId 6a66e391-9a1d-4349-8a04-64751edf692b has exceeded the frequency capping for perHour
[6893:775:0911/134316.969104:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[6893:775:0911/134316.969177:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[6893:775:0911/134316.969246:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[6893:775:0911/134316.969463:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: fdfeee55-dbb1-4eda-887e-5156c9299356
  parentUuid: 144bfb8a-4262-4cd0-9c51-4601e9e3feef
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: technology & computing
  title: Technology & Computing
  body: Technology & Computing
  targetUrl: https://brave.com/purchase-intent-test
[6893:775:0911/134316.970027:VERBOSE1:ads_service_impl.cc(2034)] Timeout ad notification with uuid fdfeee55-dbb1-4eda-887e-5156c9299356 in 120 seconds
[6893:775:0911/134316.970255:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid fdfeee55-dbb1-4eda-887e-5156c9299356 and d9dc0028-8f86-4c92-b25d-981bc1bdb903 creative instance id
[6893:775:0911/134316.971138:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: technology & computing
  targetUrl: https://brave.com/purchase-intent-test
  geoTarget: US
  confirmationType: view

Show other ad after parent-child purchase intent ad

[6948:775:0911/134801.307719:VERBOSE1:ads_impl.cc(750)] Serving ad from categories:
[6948:775:0911/134801.307809:VERBOSE1:ads_impl.cc(752)]   technology & computing-software
[6948:775:0911/134801.307851:VERBOSE1:ads_impl.cc(752)]   personal finance-personal finance
[6948:775:0911/134801.307885:VERBOSE1:ads_impl.cc(752)]   food & drink-vegetarian
[6948:775:0911/134801.307919:VERBOSE1:ads_impl.cc(752)]   gamer-pc purists
[6948:775:0911/134801.307952:VERBOSE1:ads_impl.cc(752)]   gamer-mainstream enthusiasts
[6948:775:0911/134801.307984:VERBOSE1:ads_impl.cc(752)]   gamer-alpha influencers
[6948:775:0911/134801.308731:VERBOSE1:ads_impl.cc(768)] No eligible ads found in categories:
[6948:775:0911/134801.308791:VERBOSE1:ads_impl.cc(770)]   technology & computing-software
[6948:775:0911/134801.308828:VERBOSE1:ads_impl.cc(770)]   personal finance-personal finance
[6948:775:0911/134801.308862:VERBOSE1:ads_impl.cc(770)]   food & drink-vegetarian
[6948:775:0911/134801.308896:VERBOSE1:ads_impl.cc(770)]   gamer-pc purists
[6948:775:0911/134801.308928:VERBOSE1:ads_impl.cc(770)]   gamer-mainstream enthusiasts
[6948:775:0911/134801.308961:VERBOSE1:ads_impl.cc(770)]   gamer-alpha influencers
[6948:775:0911/134801.308994:VERBOSE1:ads_impl.cc(786)] Serving ad from parent categories:
[6948:775:0911/134801.309028:VERBOSE1:ads_impl.cc(788)]   technology & computing
[6948:775:0911/134801.309080:VERBOSE1:ads_impl.cc(788)]   personal finance
[6948:775:0911/134801.309161:VERBOSE1:ads_impl.cc(788)]   food & drink
[6948:775:0911/134801.309203:VERBOSE1:ads_impl.cc(788)]   gamer
[6948:775:0911/134801.311175:VERBOSE2:eligible_ads_pacing_filter.cc(31)] 1 eligible ads after pacing
[6948:775:0911/134801.311241:VERBOSE2:eligible_ads_priority_filter.cc(81)] 1 eligible ads with a priority of 1
[6948:775:0911/134801.311304:VERBOSE1:ads_impl.cc(863)] Found 1 eligible ads
[6948:775:0911/134801.311618:VERBOSE1:ads_impl.cc(1118)] Ad notification shown:
  uuid: e4d6e48c-f667-4b54-b953-719c03ad835c
  parentUuid: 2a4aa99e-aeb2-4526-aa7a-8f5f9189eb93
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: technology & computing
  title: Technology & Computing
  body: Technology & Computing
  targetUrl: https://brave.com/purchase-intent-test
[6948:775:0911/134801.312071:VERBOSE1:ads_service_impl.cc(2034)] Timeout ad notification with uuid e4d6e48c-f667-4b54-b953-719c03ad835c in 120 seconds
[6948:775:0911/134801.312206:VERBOSE3:ad_notification_event_viewed.cc(30)] Viewed ad notification with uuid e4d6e48c-f667-4b54-b953-719c03ad835c and d9dc0028-8f86-4c92-b25d-981bc1bdb903 creative instance id
[6948:775:0911/134801.312398:VERBOSE1:confirmations.cc(119)] Confirm ad:
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: technology & computing
  targetUrl: https://brave.com/purchase-intent-test
  geoTarget: US
  confirmationType: view

Visited www.cnet.com and confirmed intent signals are added to purchaseIntentSignalHistory

[6993:775:0911/132226.879534:VERBOSE1:purchase_intent_classifier.cc(97)] Extracting purchase intent signal from visited URL
[6993:775:0911/132226.879588:VERBOSE1:purchase_intent_classifier.cc(105)] Extracted purchase intent signal from visited URL

  "purchaseIntentSignalHistory": {
    "gamer-alpha influencers": [
      {
        "timestamp_in_seconds": 1599844946,
        "weight": 1
      }
    ]
  },

Searched for amd in via URL bar (Google is the SE) and confirmed intent signals are added to purchaseIntentSignalHistory

[7048:775:0911/132730.818984:VERBOSE1:purchase_intent_classifier.cc(97)] Extracting purchase intent signal from visited URL
[7048:775:0911/132730.819387:VERBOSE1:purchase_intent_classifier.cc(105)] Extracted purchase intent signal from visited URL

  "purchaseIntentSignalHistory": {
    "gamer-alpha influencers": [
      {
        "timestamp_in_seconds": 1599845250,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1599845250,
        "weight": 1
      }
    ],
    "gamer-mainstream enthusiasts": [
      {
        "timestamp_in_seconds": 1599845250,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1599845250,
        "weight": 1
      }
    ],
    "gamer-pc purists": [
      {
        "timestamp_in_seconds": 1599845250,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1599845250,
        "weight": 1
      }
    ]
  },

@kjozwiak kjozwiak mentioned this issue Sep 15, 2020
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Ads
Archived in project
Milestone
1.14.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fixes Brave Ads Purchase Intent segments should fall back to parent segments brave/brave-core
5 participants
@tmancey @kjozwiak @LaurenWags @btlechowski @GeetaSarvadnya