Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Update icon for macOS Big Sur? #11002

Closed
ghost opened this issue Jul 29, 2020 · 18 comments · Fixed by brave/brave-core#7285
Closed

[Desktop] Update icon for macOS Big Sur? #11002

ghost opened this issue Jul 29, 2020 · 18 comments · Fixed by brave/brave-core#7285
Labels
closed/duplicate Issue has already been reported OS/Desktop OS/macOS

Comments

@ghost
Copy link

ghost commented Jul 29, 2020 •
edited by w0ts0n
Loading

Description

Suggestion to update the icon for the macOS version of Brave to match the new macOS Big Sur icon style?

Steps to Reproduce

  1. Upgrade to macOS Big Sur.
  2. Look at the Apple icons.
  3. Look at the Brave icon.

Actual result:

Screen Shot 2020-07-29 at 2 50 01 PM

Expected result:

User new Brave icon set for Big Sur: gdrive

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

All of them

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Sort of...
    Screen Shot 2020-07-29 at 2 50 30 PM
@ghost ghost added the OS/Desktop label Jul 29, 2020
@kenherbert
Copy link

Third party apps should not have to conform to Apple's choice of style and should remain consistent with their own branding.

I would not want LibreOffice, Thunderbird, GIMP or any of my other third party apps to change their icon for no real reason.

@ghost
Copy link
Author

ghost commented Aug 1, 2020

I completely understand that and agree to an extent. However, in this issue, I'm mainly referring to the macOS version of the app as I would probably not expect cross-platform apps to use the Big Sur style on Windows and Linux for instance. Now, if there is no way to change the icon for just the macOS app without affecting the other platforms, that is understandable and I can close the issue.

@bsclifton
Copy link
Member

cc: @rebron @karenkliu

@kenherbert
Copy link

Unless Apple impose a style guide on app icons on MacOS there should not be a change (and if they do want to do this, Apple should borrow Android's method of checking the icon programmatically and putting it in an appropriately sized box if it does not conform).

No other third party apps I used have adopted Apple's icon style (and even Apple's own apps have 2+ different styles on Mojave):
Screen Shot 2020-08-03 at 1 42 16 pm

The Big Sur icon style may last one version, it may last 10, it may last 100 (but I doubt it). Only Apple can say (and even they probably don't know right now), so Brave would need to change their icon again the next time Apple decides on a stylistic change to their system app icons.

@ghost
Copy link
Author

ghost commented Aug 3, 2020

Alright, I guess that makes sense. At this point I’ll leave it up to Brave then. If they’re interested, they’ll do it and if not they won’t ¯_(ツ)_/¯

@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Aug 4, 2020
@bradleyrichter
Copy link

@gottabeleGIT Thanks for your contribution. We will investigate what is the best app icon approach for Brave in Big Sur. We can certainly use a specific set for Mac OS if needed.

At a minimum, we will reduce the icon height to fit better on the dock mixed in with the new iOS-like approach they will be
using.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Aug 7, 2020
@cperezabo
Copy link

It's been months since I created #8662. If a simple resize which cannot take more than 30 seconds is taking months, I don't want to imagine how long will it take to make the resize plus put it in a square frame...

@bsclifton
Copy link
Member

bsclifton commented Nov 5, 2020 •
edited
Loading

@cperezabo I can understand the frustration and I'm sorry ☹️ While this might be a 30 second task, it would need to be reviewed and tested... and there are a lot of competing tasks.

If you check our issue log, there are over 2,600 issues and some are really bad (crashing, always showing reCAPTCHA, needing to upgrade Chromium to get latest security fixes, etc). @rebron assigned this issue and #8662 a P4 which means it's fairly low on our list (but it is on our list)

@cperezabo
Copy link

cperezabo commented Nov 7, 2020 •
edited
Loading

I understand, but come on guys, we are not asking to change the color of a random button... It's the app icon in the macOS dock, which has some globally followed sizes and shapes that you are not respecting at all, and it will be even more noticeable with Big Sur in some days as shown in this issue.

@bsclifton
Copy link
Member

bsclifton commented Nov 9, 2020 •
edited
Loading

@cperezabo fix for the issue you reported by @simonhong up now in brave/brave-core#7086

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 27, 2020
@rebron rebron removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Nov 27, 2020
@simonhong simonhong added this to the 1.19.x - Nightly milestone Dec 1, 2020
@brave-builds brave-builds mentioned this issue Dec 1, 2020
Closed
4 tasks
@karenkliu
Copy link

@karenkliu can you new add icon for development also?
image

Hi @simonhong , did you still need this from me?

@simonhong
Copy link
Member

@karenkliu It's not mandatory because this icon is only used for local unofficial build.
but I think it would be good to have same style icon for development icon.
If you share it, I'll udpate.

@simonhong simonhong removed this from the 1.19.x - Beta milestone Dec 2, 2020
@simonhong simonhong reopened this Dec 2, 2020
@bsclifton
Copy link
Member

@simonhong should this be re-opened after brave/brave-core#7308 was merged?

@rebron rebron mentioned this issue Dec 2, 2020
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Dec 2, 2020

@simonhong should this be re-opened after brave/brave-core#7308 was merged?

Re-opening as this was reverted as per the above.

@kjozwiak kjozwiak reopened this Dec 2, 2020
@simonhong
Copy link
Member

Will close this because @rebron created another issue for icon update. - #13005

@simonhong simonhong added the closed/duplicate Issue has already been reported label Dec 2, 2020
@rebron rebron removed QA/No misc/icons priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude labels Jan 20, 2021
@zevrix
Copy link

zevrix commented Feb 24, 2021 •
edited
Loading

Brave icon now has changed - and it's really bad. Please restore the original Brave icon - which is a masterpiece.

P.S. here's a much better idea if you have to follow the squarish shape while retaining a powerful impressive icon:

brave-icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported OS/Desktop OS/macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update app icons on macOS brave/brave-core