Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp images being blocked on https://www.infowars.com/ #1071

Closed
rebron opened this issue Sep 9, 2018 · 2 comments
Closed

wp images being blocked on https://www.infowars.com/ #1071

rebron opened this issue Sep 9, 2018 · 2 comments

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 9, 2018

Moving over from browser-laptop: brave/browser-laptop#15096

Description

This one was reported from the community:

It looks like the following images are now being blocked:

https://www.infowars.com/wp-content/uploads/2018/08/DownloadFreeInfowarsOfficial-hero-385.png
https://www.infowars.com/wp-content/themes/infowars-sitegoals/images/logo.png
https://www.infowars.com/wp-content/themes/infowars-sitegoals/images/mlogo.png
https://www.infowars.com/wp-content/themes/infowars-sitegoals/images/backing.png
https://www.infowars.com/wp-content/themes/infowars-sitegoals/images/footer-logo.png
https://www.infowars.com/wp-content/themes/infowars-sitegoals/images/play.png
https://www.infowars.com/wp-content/uploads/2018/08/robot.png
https://www.infowars.com/wp-content/themes/infowars-sitegoals/images/alex.png

This was working on brave-core a few versions ago but now has the same behaviour as b-l. I'm assuming there was an update to one of our lists that might have regressed this. Those images shouldn't be blocked.

Steps to Reproduce

  1. download & install the latest b-l (used 0.23.79 51b4905)
  2. visit https://www.infowars.com/

You'll notice that the top banner is missing several images.

Actual result:

screen shot 2018-08-28 at 11 26 12 am

screen shot 2018-08-28 at 11 27 20 am

Expected result:

screen shot 2018-08-28 at 11 28 59 am

Reproduces how often:

100% reproducible using the above STR.

Brave Version

about:brave info:

 Brave: 0.23.79 
V8: 6.8.275.24 
rev: 51b49051a779f0db94fbcfd0df5faca781299ea0 
Muon: 8.0.7 
OS Release: 17.7.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 68.0.3440.84

Reproducible on current live release:

Yes, currently reproducible under 0.23.79 51b49051a779f0db94fbcfd0df5faca781299ea0 which is the latest release.

Additional Information

@rebron rebron added bug feature/shields/adblock Blocking ads & trackers with Shields webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Sep 9, 2018
@rebron rebron added this to the 2.x Backlog milestone Sep 9, 2018
@bbondy bbondy modified the milestones: 2.x Backlog, 1.x Backlog Sep 30, 2018
@tildelowengrimm tildelowengrimm added priority/P5 Not scheduled. Don't anticipate work on this any time soon. webcompat/shields Shields is breaking a website. and removed webcompat/not-shields-related Sites are breaking because of something other than Shields. feature/shields/adblock Blocking ads & trackers with Shields labels Nov 5, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@kjozwiak
Copy link
Member

Still an issue with the following build:

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

@kjozwiak kjozwiak added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label Apr 18, 2019
@rebron
Copy link
Collaborator Author

rebron commented Jul 4, 2019

Screen Shot 2019-07-03 at 5 51 21 PM

Closing. Original issue is fixed in Version 0.68.89 Chromium: 75.0.3770.100

@rebron rebron closed this as completed Jul 4, 2019
@kjozwiak kjozwiak added closed/invalid and removed bug webcompat/shields Shields is breaking a website. priority/P5 Not scheduled. Don't anticipate work on this any time soon. webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants