Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Searches performed on https://www.xda-developers / https://forum.xda-developers.com don't go through. #10487

Closed
thanuj10 opened this issue Jun 26, 2020 · 6 comments
Assignees
Labels
closed/fixed-by-component-update feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website. workaround/allow-ads-and-tracking

Comments

@thanuj10
Copy link

Description

Searches performed on https://www.xda-developers.com and https://forum.xda-developers.com don't go through with Adblocking enabled.

Steps to Reproduce

  1. Visit either XDA-Developers or XDA Developer Forums
  2. Peform a search by clicking on the magnifying glass icon on the top right of the webpage
  3. Type some keywords

Actual result:

Searches don't go through and no suggestions pop-up.

Expected result:

Searches work asusual with suggestions popping up and changing with every key word entered or altered.

Reproduces how often:

Easily Reproduced consistently.

Brave version (brave://version info)

Version - 1.12.51 Chromium: 83.0.4103.116 (Official Build) nightly (64-bit)
Revision - 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}

Version/Channel Information:

Tested on Nightly only.

  • Can you reproduce this issue with the current release? Not sure
  • Can you reproduce this issue with the beta channel? Not sure
  • Can you reproduce this issue with the dev channel? Not sure
  • Can you reproduce this issue with the nightly channel? Yes.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

None.

@srirambv srirambv added feature/shields/adblock Blocking ads & trackers with Shields webcompat/shields Shields is breaking a website. webcompat/not-shields-related Sites are breaking because of something other than Shields. workaround/allow-ads-and-tracking labels Jun 26, 2020
@srirambv
Copy link
Contributor

cc: @ryanbr

@ryanbr
Copy link

ryanbr commented Jun 28, 2020

Fixed in Easylist.

Give it 24-48hrs. easylist/easylist@0f0861c

Will leave ticket open once confirmed everything is working

@ryanbr ryanbr self-assigned this Jun 28, 2020
@thanuj10
Copy link
Author

I can also confirm the same behaviour on Mobile. Should I open an issue separately?

@ryanbr
Copy link

ryanbr commented Jun 28, 2020

the mobile (android) will also be fixed, shares the same list.

@thanuj10
Copy link
Author

thanuj10 commented Jun 29, 2020

I can confirm that this issue is now fixed.

@ryanbr
Copy link

ryanbr commented Jul 5, 2020

Thanks @thanuj10 , closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/fixed-by-component-update feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website. workaround/allow-ads-and-tracking
Projects
None yet
Development

No branches or pull requests

3 participants