Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] add labels for FF installations when importing #10148

Open
LaurenWags opened this issue Jun 8, 2020 · 2 comments
Open

[Desktop] add labels for FF installations when importing #10148

LaurenWags opened this issue Jun 8, 2020 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

With C83 it looks like we can now import from various (Release, Beta, Nightly) versions of FF, whereas with C81 we could only import from Release. Now that we can import from other installations, it would be good to label these in the import drop down, otherwise users won't know which one they're importing from.

Note - it looks like this is working on Win 7 per @btlechowski (win 7 has FF labels in import drop down) however we should check this on Win 10 and Linux before labeling this issue as macOS only.

Steps to Reproduce

  1. Pre-req - have multiple FF installations (Release, Beta, Nightly are what I have) with data
  2. Clean profile 1.10.x
  3. On welcome screen navigate to Import slide

Actual result:

See multiple FF profiles, but no idea which one is which.
Screen Shot 2020-06-08 at 11 46 15 AM

Expected result:

FF profiles should be labeled - perhaps with a - Release at the end or the similar

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a for 1.9.x, yes for upcoming 1.10.x
  • Can you reproduce this issue with the beta channel? yes for 1.11.x
  • Can you reproduce this issue with the dev channel? yes for 1.11.x
  • Can you reproduce this issue with the nightly channel? unsure, probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

for reference, this is when importing from 1.9.x on same machine:

Screen Shot 2020-06-08 at 11 45 05 AM

cc @rebron @brave/legacy_qa to check other platforms

@btlechowski
Copy link

Not reproducible on Windows 7

Verified on 1.10.x, 1.11.x, 1.12.x

image
image

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". OS/macOS labels Jun 9, 2020
@GeetaSarvadnya
Copy link

The issue is reproducible Window 10x64 in both 1.18.x and 1.20.x


Brave | 1.20.40 Chromium: 88.0.4315.5 (Official Build) nightly (64-bit)
-- | --
Revision | d2abe4588adaeb0d66aa0a0106675be1dff12c64-refs/branch-heads/4315@{#11}
OS | Windows 10 OS Version 2004 (Build 19041.685)


Brave | 1.18.75 Chromium: 87.0.4280.101 (Official Build) (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)

I have only one version of Firefox installed in my machine. I could see duplicate Mozilla Firefox option listed twice in the brave://welcome import bookmarks and settings slide

1.18.x
image

1.20.x
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: P4 Backlog
Development

No branches or pull requests

4 participants