Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm run verify as a git commit hook #1

Open
pes10k opened this issue May 31, 2020 · 6 comments
Open

Add npm run verify as a git commit hook #1

pes10k opened this issue May 31, 2020 · 6 comments

Comments

@pes10k
Copy link
Collaborator

pes10k commented May 31, 2020

Just to ensure that we never wind up with bad json here, and potentially breaking the DAT, WDYT of adding npm run verify as a commit hook?

@pes10k
Copy link
Collaborator Author

pes10k commented May 31, 2020

@antonok-edm ^^^

@antonok-edm
Copy link
Collaborator

I was hoping it could be added as a CI step eventually. I guess a hook would work too, but as far as I'm aware hooks can only be added manually on the client side.

@antonok-edm
Copy link
Collaborator

As of #4, this is becoming increasingly necessary.

@myreli
Copy link

myreli commented Nov 16, 2020

Is anyone working on this?

What do you have in mind, a manual set up at post-install and .git/hooks or something like husky?

@antonok-edm
Copy link
Collaborator

@myreli nobody's working on it at the moment, although we are happy to accept PRs 😄.

Leveraging npm install in some way to setup a git hook sounds like an excellent idea!

@myreli
Copy link

myreli commented Nov 18, 2020

@antonok-edm cool! I will start working on it them 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants