You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like several rules in the debounce.json are unsupported or broken in subtle ways (see #869 for example) and while the main concern is webcompat, these could also lead to more serious problems because we are redirecting to different URLs than the intended ones.
We should therefore audit all of the existing rules to ensure that they are redirecting to the intended destination URL (and that they are using the tightest possible hostname).
The rules pulled in from external sources will need a bit more work since we need to find examples of them in the wild (e.g. by googling for them) before we can review the URL pattern and determine the URL encoding used.
It looks like several rules in the
debounce.json
are unsupported or broken in subtle ways (see #869 for example) and while the main concern is webcompat, these could also lead to more serious problems because we are redirecting to different URLs than the intended ones.We should therefore audit all of the existing rules to ensure that they are redirecting to the intended destination URL (and that they are using the tightest possible hostname).
All of the rules added since the initial import I looked at have example URLs (thank you @ryanbr !): https://github.com/brave/adblock-lists/pulls?page=1&q=is:pr+is:closed+label:Debounce
The rules pulled in from external sources will need a bit more work since we need to find examples of them in the wild (e.g. by googling for them) before we can review the URL pattern and determine the URL encoding used.
Tracking spreadsheet:
https://docs.google.com/spreadsheets/d/1URl6N_IEZGXfiui6m6XqMiLJgHeHzkvnJedw4gq8Mis/edit#gid=0
The text was updated successfully, but these errors were encountered: