Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit all debouncing rules #871

Closed
fmarier opened this issue May 28, 2022 · 1 comment
Closed

Audit all debouncing rules #871

fmarier opened this issue May 28, 2022 · 1 comment
Assignees
Labels
Debounce Debouncing list related

Comments

@fmarier
Copy link
Member

fmarier commented May 28, 2022

It looks like several rules in the debounce.json are unsupported or broken in subtle ways (see #869 for example) and while the main concern is webcompat, these could also lead to more serious problems because we are redirecting to different URLs than the intended ones.

We should therefore audit all of the existing rules to ensure that they are redirecting to the intended destination URL (and that they are using the tightest possible hostname).

All of the rules added since the initial import I looked at have example URLs (thank you @ryanbr !): https://github.com/brave/adblock-lists/pulls?page=1&q=is:pr+is:closed+label:Debounce

The rules pulled in from external sources will need a bit more work since we need to find examples of them in the wild (e.g. by googling for them) before we can review the URL pattern and determine the URL encoding used.

Tracking spreadsheet:
https://docs.google.com/spreadsheets/d/1URl6N_IEZGXfiui6m6XqMiLJgHeHzkvnJedw4gq8Mis/edit#gid=0

@fmarier
Copy link
Member Author

fmarier commented Jun 28, 2022

Here are the results of auditing all of the existing debounce rules:

  • Removed: 66 rules (59 from external import)
  • Changed: 37 rules (mostly tighter URL patterns)
  • Added: 10 rules (new bouncers discovered while investigating existing ones)

List of PRs:

There is now documentation for this feature including how to write rules (and what edge cases to look out for).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debounce Debouncing list related
Projects
None yet
Development

No branches or pull requests

2 participants