This repository has been archived by the owner on Mar 6, 2019. It is now read-only.
Fixed catalog is downloaded twice on startup #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the catalog always downloaded on browser startup? That's a privacy issue if it is. We obviously need to download when ads is enabled, but after that it should happen on a randomized schedule |
|
Catalog is downloaded on browser start as if the catalog is out of date then tokens for confirmations could fail to redeem |
|
@tmancey we just can't do that for privacy reasons because it becomes a proxy for browser usage. I'm going to open a ticket for it. |
|
Sure let’s raise with jimmy and security team so we can try to unblock ASAP |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #68