Skip to content
This repository has been archived by the owner on Mar 6, 2019. It is now read-only.

catalog should not be downloaded on every startup #140

Open
bridiver opened this issue Feb 20, 2019 · 6 comments
Open

catalog should not be downloaded on every startup #140

bridiver opened this issue Feb 20, 2019 · 6 comments

Comments

@bridiver
Copy link
Collaborator

from #139 catalog is downloaded on browser startup, but that's a problem for privacy. The reasoning for token redemption also doesn't seem valid because many people (myself included) keep the browser open for weeks at a time. It can happen immediately when ads is enabled, but after that it should happen on a randomized schedule that is independent of browser startup/shutdown.

@bridiver
Copy link
Collaborator Author

there is no security/privacy review label here so cc @diracdeltas

@bridiver
Copy link
Collaborator Author

there is also the opposite issue if you frequently open/close the browser during the day

@tmancey
Copy link
Collaborator

tmancey commented Feb 20, 2019

This issue fix a bug where the catalog was downloaded twice on startup. The logic where the catalog is downloaded on browser startup is legacy from Muon codebase so we need to decide if this is an issue

@jsecretan
Copy link

I don't think this is currently a problem, because the catalog is not only downloaded on startup, but on 2 hour intervals with 10% jitter.

@bridiver
Copy link
Collaborator Author

so as discussed on Slack I think the most urgent problem is that there is no minimum time between downloads so successive restarts of the browser would trigger frequent catalog downloads, but if anything the 2 hour interval makes it even easier to track browser usage because we're getting frequent pings that will stop when the browser is closed.

@bridiver bridiver reopened this Feb 20, 2019
@diracdeltas
Copy link

given the frequency of this ping, i think it's valid to require more variance in the pings and avoid it on restarts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants