You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 12, 2020. It is now read-only.
Description: Ads can occasionally be seen on Twitch even with shields enabled. For instance, a Galaxy Note 9 pre-roll advertisement can be seen before loading Ninja's Twitch stream.
Ease of Reproducibility: Medium (inconsistent)
Brave:
Brave-muon: Yes
Brave-core: TBD
Initial Investigation:
(Luke Mulks' work below.)
This is the request for the playlist containing the ad manifest that the player's ad SDK is using:
We likely need to look a couple requests behind this one to make sure. For what we block. An aside - adding here to reference later. Below is the experiments.json request, which responds with mappings containing experiment IDs that twitch is running. Noting so we can put this on file for debugging.
Call that twitch makes for the experiments: Request URL: https://www.twitch.tv/experiments.json
The video player SDK makes an ad request to the video ad server.
The video player appears to block Amazon ad requests. I'm seeing something google-related which may or may not be a factor here.
Most of these live/longform vod player configs will have a hard coded backup asset, which basically serves as a 1st party ad from the CDN that hosts the video content. Given that we observe Samsung ads, and that I see Samsung has sponsored takeovers across Twitch with ads disabled, it could be that Twitch has a Samsung video ad hard coded as the failover for the ad.
The other possibility is that Twitch has a set of ad vendors in the player config, and we block some but not all of them.
Regardless of 3 and 4, both would result in inconsistent repro.
uBlock Origin prevents ads from playing on Twitch. I'm not sure how, but I have never seen an ad on Chrome with uBlock Origin enabled. Started using Brave today and started seeing ads.
Description: Ads can occasionally be seen on Twitch even with shields enabled. For instance, a Galaxy Note 9 pre-roll advertisement can be seen before loading Ninja's Twitch stream.
Ease of Reproducibility: Medium (inconsistent)
Brave:
Brave-muon: Yes
Brave-core: TBD
Initial Investigation:
(Luke Mulks' work below.)
This is the request for the playlist containing the ad manifest that the player's ad SDK is using:
Request URL: https://video-weaver.sjc02.hls.ttvnw.net/v1/playlist/CscDL_f6--R9uzeupTm50po90-X8enQkdjcevLyX2uJmVIKjLHYZopebcPISIDYGDMt2QPGZIxOOrtOUO4zD1mukpE0GQ2_OKPkikPRGXlOgFejejVm1ab9eU8SSZcOslhXQYDD6poz6F5adXw6t5kfpYf-PWKMcQwhTOB81j0uAxGPtrtqLKZ1henjkT4PspBpScxSj2SPxr6pcSF_xLrQRywDrEo5KHP8LNfroejTqSfnfC75GtYnbP2rQc89FpPgho4Y5keg8TIKnEwxisAKIbIjbQzSLdsOCEJv9d5fUNxlFs-0Q2h7TUKcAh29S7PO3i58yQsrCg_z4vOL5GDTNrk9XAAHm97OqrOztkDMLEzPesJ_z_ktKUhhw-M0SqOndBi1DBU5sIIz_DJYBCtyZnV40TINpHljxQt2lOxbTTXRNLCZCHT6bUIohRvUQsbNe7D1I8lyRcobwumnxzSBXasTwcx5I2tHu27Cfh0hvPMGiL5k-My8i-YOv1dd2-gzxsPCLH_lm5fg1QBl-b4XwqpYhWU91cd7cvIBqhvlF3ezYWCxFBAZkSJo8YBaUu6KeStHNlSdC2E66ViJPQAEk-fnbF3EmpH4SEPnbGr4nLpXmtgSW4kcXy8waDHO3W1DD87Wm9Qt79A.m3u8
This is the response:
We likely need to look a couple requests behind this one to make sure. For what we block. An aside - adding here to reference later. Below is the
experiments.json
request, which responds with mappings containing experiment IDs that twitch is running. Noting so we can put this on file for debugging.Call that twitch makes for the experiments:
Request URL: https://www.twitch.tv/experiments.json
Note: Import for human-readability: Response_with_the_experiment_mapping_ids.txt
Here's what I think we're seeing here:
Regardless of 3 and 4, both would result in inconsistent repro.
Corroborated by user(s): https://www.reddit.com/r/BATProject/comments/9avra0/twitch_ads_showing_while_using_brave_with_shields/
The text was updated successfully, but these errors were encountered: