Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cover be mapped to multi-relay devices #2951

Open
3 tasks done
michalk-k opened this issue Jan 12, 2025 · 7 comments
Open
3 tasks done

Allow cover be mapped to multi-relay devices #2951

michalk-k opened this issue Jan 12, 2025 · 7 comments
Labels

Comments

@michalk-k
Copy link
Contributor

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

After adding the Shelly 2.5 and the Shelly Plus 2PM I realized, that covers are not covered by current PowerCalc functionality. So my Shelly 2.5 configured to control motorized window cannot be automatically added via discovery.

Describe the solution you'd like

An activation of one relay results in an opening of the cover, and activation of another one, results in closing it.
Both relays cannot be enabled at the same time. It would cause damage to the motorized window *)

Home Assistant provides 4 states for covers: closed, closing, opened, and opening.
I assume that

  • stand_by consumption should be applied for states closed and opened. It's because both relays are turned off at that time
  • additional consumption equal to single relay active should be added to stand_by consumption when the cover state is either closing or opening.

*) it's possible that turning on both relays can be valid for some specific motorized windows. I have no experience with such. I would expect it would be very short time event, though

Describe alternatives you've considered

I expect it's possible to achieve with templates used in PC configuration. Not checked though.

Additional context

N/A

@michalk-k michalk-k added the enhancement New feature or request label Jan 12, 2025
@bramstroker
Copy link
Owner

Implemented with #2953

@michalk-k
Copy link
Contributor Author

It was quick :)

@bramstroker
Copy link
Owner

@michalk-k can you verify if this is also fixed for you in v1.17.1? Then the issue can be closed

@michalk-k
Copy link
Contributor Author

michalk-k commented Jan 18, 2025

I can confirm as follows:

  1. It shows the option to allow adding the cover entity.
  2. The cover entity (the only one available) is listed in the drop=box
  3. it doesn't select this entity automatically
  4. not tested if it works correctly with cover-specific states (I will test it later)

If .4 is functional, I would agree with merging to major build, improving the UI latter.

Tested with 1.17.2

@bramstroker
Copy link
Owner

  1. it doesn't select this entity automatically

This is implemented with #2975

If .4 is functional, I would agree with merging to major build, improving the UI latter.

What do you mean with "merging to major build, improving the UI latter."?

@michalk-k
Copy link
Contributor Author

michalk-k commented Jan 19, 2025

I meant that missing pre-selecting entity (implemented in #2975) is not a stopper for releasing the feature, if working with cover states is implemented (I still have to confirm that if anyone else didn't)

@bramstroker
Copy link
Owner

@michalk-k the feature was already released, otherwise you couldn't have tested in v1.17.2 ;-).
Cover states should work, have written several tests for that to verify the behaviour.
Even a mix of cover and switch entities should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants