Prevent calling requestsDismissalOfViewController #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix prevents calling requestsDismissalOfViewController when there is nothing to dismiss. The same way `requestsPresentationOfViewController` is not being called. This is also crashing on runtime on swift as this is passing `nil` to a function signature that is mark as `non_null`.
Reflejo
force-pushed
the
fix-nil-vc-nonios9
branch
from
58093d5
to
077ee24
Compare
|
Cool, thanks for this. I wonder if we could reasonably just move this check to the |
|
@burnto That was my first approach. Wasn't sure what to do with else {
[[BTLogger sharedLogger] critical:@"Unable to dismiss View Controller to end PayPal flow. BTPayPalDriver needs a viewControllerPresentingDelegate<BTViewControllerPresentingDelegate> to be set."];
}but yeah, seems safer to do it there |
|
This PR looks good to me. In the Thanks, @Reflejo ! |
intelliot
added a commit
that referenced
this pull request
Nov 30, 2015
Prevent calling requestsDismissalOfViewController
|
Any chance to bump the podspec version with this fix? It was pretty bad on non ios9 |
|
Ah just saw it, never mind. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix prevents calling requestsDismissalOfViewController when there is nothing to dismiss. The same way
requestsPresentationOfViewControlleris not being called when there is nothing to present.Before this, the library was crashing on runtime when using swift and iOS < 9 as this is passing
nilto a function signature that is marked asnon_null.