Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App installed check #1233
App installed check #1233
Changes from 4 commits
45a199e
1732446
68d6fbc
38c9f33
880d04f
50f5f76
b29540f
a700593
afd723b
1b92c9d
5ee9242
f872643
57167a8
738967f
5124804
e0d960e
b9edf9d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of asserting that the function
isPayPalAppInstalled
returns some boolean, we rather want our unit tests to assert on the component's public API (in this caseBTPayPalClient
). Implementation details (such as if the app installed check lives in a method or not) should be able to change without breaking our unit tests.So this test should assert on the end result behavior, which is that the API POST request to
/v1/paypal_hermes/create_payment_resource
does include the app switch params if the app is installed, and does not include the app switch params if the app is not installed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I've made changes to test the endpoints