Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional dependencies/Behaviour-based 'tools'? #24

Closed
amokan opened this issue Oct 23, 2023 · 2 comments · Fixed by #223
Closed

Optional dependencies/Behaviour-based 'tools'? #24

amokan opened this issue Oct 23, 2023 · 2 comments · Fixed by #223

Comments

@amokan
Copy link
Contributor

amokan commented Oct 23, 2023

Given that the crawling effort was merged in (which adds deps for :floki and :crawly) and the existing :abacus dependency, is there a planned effort to make these sorts of deps optional and maybe implement some sort of behaviour to facilitate making things more flexible for consumers of the project?

I'd be willing to help on this if there is interest.

Nothing at all wrong with any of the deps, but not every use-case will need them.

@warnero
Copy link

warnero commented Oct 23, 2023

Hasn't been merged yet :). I wasn't sure how to do optional dependencies. And for sure on the behaviour front. Just trying to get stuff working and then fine-tuning.

Definitely think there will be interest.

@amokan
Copy link
Contributor Author

amokan commented Oct 23, 2023

@warnero Thank you for the heads up! For some reason I thought that was merged. I will try to glance at that PR again later today and add some notes on making the dependencies optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants