Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classification + Analysis step Inefficiencies #356

Closed
JuiceSackey opened this issue Sep 16, 2021 · 2 comments
Closed

Classification + Analysis step Inefficiencies #356

JuiceSackey opened this issue Sep 16, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@JuiceSackey
Copy link

Hello,

It seems like classification and analysis step of the program take entirely too long for my dataset (~1 day for each step).
We are analyzing whole brain cfos expression, so there are over 700k cells, which is probably contributing to this issue. I raised an issue on the forums and I was told it may be due to inefficiencies in the coding for these steps and to raise the issue here.
The data is all stored/written to an internal HDD.

This is a log file for just analysis ran:
cellfinder_2021-09-05_09-30-11_log.txt

This is a log file with the classification+analysis step run:
cellfinder_2021-09-07_13-31-22_log.txt

As you can imagine, this is a pretty big bottleneck in processing our data.
Please let me know if you need any more information. Thanks!

My specs are as below:

  • OS: Ubuntu
  • Version 18.04.5 LTS
  • Hardware specs: 64GB RAM, AMD® Ryzen 9 3900x 12-core processor × 24 CPU, GeForce RTX 2080 Ti/PCIe/SSE2 GPU
@JuiceSackey JuiceSackey added the bug Something isn't working label Sep 16, 2021
@adamltyson adamltyson added enhancement New feature or request and removed bug Something isn't working labels Sep 17, 2021
@adamltyson
Copy link
Member

I've removed the bug label, as technically everything is working correctly, just very slow on big datasets, but this does need to be improved.

I don't know when I'll get time to look at this, but I would hope it shouldn't be too complex.

@adamltyson adamltyson removed their assignment Feb 14, 2022
willGraham01 referenced this issue Sep 1, 2023
* Forbid import when tensorflow is not installed

* Update README with conda trickeries
@willGraham01 willGraham01 transferred this issue from brainglobe/cellfinder Dec 13, 2023
@adamltyson adamltyson transferred this issue from brainglobe/brainglobe-workflows Jan 4, 2024
@adamltyson
Copy link
Member

There have been many changes to the the way cellfinder works since this issue was raised, many of them with the aim of speeding up this type of analysis. In particular, the next version of cellfinder with have GPU support.

I'm going to close this issue, but if problems persist, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants