Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation_domain in error messages should be set to 'validators' #181

Closed
KubaZ opened this issue Feb 5, 2014 · 3 comments
Closed

Translation_domain in error messages should be set to 'validators' #181

KubaZ opened this issue Feb 5, 2014 · 3 comments
Labels
Milestone

Comments

@KubaZ
Copy link

KubaZ commented Feb 5, 2014

Hi,
currently file /Resources/views/Form/bootstrap.html.twig has same translation_domain variable for normal messages and error messages which is not compatible with current symfony, which has validation messages in file named 'validators'. Because of that, if you set translations for your form fields in ex. 'message' file then you can't use symfony validator translations.

@florianeckerstorfer
Copy link
Member

Would it help if we have two different translation_domains? I'm not really familiar with the current state of translations since I don't use them for my current projects.

@KubaZ
Copy link
Author

KubaZ commented Feb 5, 2014

I think this is probably best solution for this problem :)

@florianeckerstorfer
Copy link
Member

I looked at how the default Symfony form template does this and they just don't supply a translation domain for error message. I have decided to do the same thing in BootstrapBundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants