Ipv6 #59
Closed
Ipv6 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import sys | ||
|
|
||
| from collections import OrderedDict | ||
| from prometheus_client import REGISTRY, start_http_server as orig_start_http_server | ||
| from prometheus_client.exposition import _ThreadingSimpleServer |
There was a problem hiding this comment.
Suggested change
| from prometheus_client.exposition import _ThreadingSimpleServer | |
| from prometheus_client.exposition import ThreadingWSGIServer |
| def start_http_server(port, addr='', registry=REGISTRY, ipv6=False): | ||
| # Monkeypatch the server class address family to support IPv6 if needed. | ||
| if ipv6: | ||
| _ThreadingSimpleServer.address_family = socket.AF_INET6 |
There was a problem hiding this comment.
Suggested change
| _ThreadingSimpleServer.address_family = socket.AF_INET6 | |
| ThreadingWSGIServer.address_family = socket.AF_INET6 |
Universal-Omega
added a commit
to miraheze/puppet
that referenced
this pull request
Sep 8, 2022
I have applied changes (braedon/prometheus-es-exporter#59) locally to es131 in order to support this.
Universal-Omega
added a commit
to miraheze/puppet
that referenced
this pull request
Sep 8, 2022
I have applied changes (braedon/prometheus-es-exporter#59) locally to es131 in order to support this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for serving metrics on IPv6 via the
--ipv6CLI flag.This branch is available as version
0.8.0a1on pypi and dockerhub for testing purposes.