Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] [dark shell] Titlebar text appears slightly off center #4785

Open
core-ai-bot opened this issue Aug 29, 2021 · 3 comments
Open

[CLOSED] [dark shell] Titlebar text appears slightly off center #4785

core-ai-bot opened this issue Aug 29, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by peterflynn
Friday Sep 13, 2013 at 16:07 GMT
Originally opened as adobe/brackets#5200


It looks like the string is being centered within the space between the app icon and the window control icons -- not within the overall window width. Since the app icons and the window icons are not the same width, this shifts the text left of center within the overall window width.

This looks good at small window sizes when it's visually clear that the passing on both sides matches in width. But it looks funny when maximized on my MBP, where the webcam lens sits just above the top center of the screen -- making it easily noticeable that the text is left of center.

May not be very high priority, but maybe worth thinking about...

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Friday Sep 13, 2013 at 21:00 GMT


Great Catch! Indeed I was using the caption rect to center and not the window. This took a little bit to wrap my head around as the fix identified a few other problems but I think it's much better now. @peterflynn Take a look if you can build or grab tonight's build when you get a chance and let me know what you think.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Friday Sep 13, 2013 at 21:01 GMT


FBNC@peterflynn

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Sunday Sep 15, 2013 at 11:10 GMT


Confirmed fixed in the "WrathOfKhan9477" build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant