[CLOSED] Fix over-repaint issue when typing

[core-ai-bot]

Issue by jasonsanjose
Thursday May 09, 2013 at 17:49 GMT
Originally opened as adobe/brackets#3767

---

Somehow, removing the default 1px border-right from CodeMirror-gutters placeholder caused the repaint issue (where the entire window repaints for each keystroke). As a fix, I've changed the border color to match the gutter background.

The problem does reproduce in a boilerplate CodeMirror demo. I'll file a bug.

---

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/3767/commits

[core-ai-bot]

Comment by njx
Thursday May 09, 2013 at 17:52 GMT

---

What the.

[core-ai-bot]

Comment by njx
Thursday May 09, 2013 at 17:54 GMT

---

[core-ai-bot]

Comment by njx
Thursday May 09, 2013 at 17:55 GMT

---

Why was the min-width change necessary?

[core-ai-bot]

Comment by jasonsanjose
Thursday May 09, 2013 at 18:11 GMT

---

Filed codemirror/codemirror5#1514.

I earlier tried removing min-width to see if that was the cause. It isn't. But I decided to convert this to pixels anyway since we use pixel size fonts. I believe this min-width use of ems here was an oversight.

[core-ai-bot]

Comment by redmunds
Thursday May 09, 2013 at 22:43 GMT

---

Done with review.

[core-ai-bot]

Comment by jasonsanjose
Friday May 10, 2013 at 17:35 GMT

---

@redmunds ready for review

[core-ai-bot]

Comment by redmunds
Friday May 10, 2013 at 18:01 GMT

---

Merging.

[core-ai-bot]

Comment by jasonsanjose
Monday May 13, 2013 at 16:44 GMT

---

@marijnh pushed a fix to CodeMirror master codemirror/codemirror5@b2c1d96 to change the gutter height from a 100% height to an explicit height. See comment here codemirror/codemirror5#1514 (comment).