Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Don't DrawMenuBar() for every menu item #245

Open
core-ai-bot opened this issue Aug 17, 2021 · 1 comment
Open

[CLOSED] Don't DrawMenuBar() for every menu item #245

core-ai-bot opened this issue Aug 17, 2021 · 1 comment

Comments

@core-ai-bot
Copy link
Member

Issue by redmunds
Saturday Nov 09, 2013 at 02:09 GMT
Originally opened as adobe#377

Doesn't seem to be necessary to DrawMenuBar() on every menu item as it's added on Windows.SetMenuTitle() already sets a time to do that.

This seems to reduce start up time by ~3/4 second on my lenovo W510 running Win7. Also draws all core menus in menubar at once, followed by a second draw for extensions. Currently, the only extension that adds a menu it the builtin Debug menu, so this should be tested with other extensions that add menus (e.g. Emmet).

This is for adobe/brackets#5266, but there may be more that can be done.

Windows-only.

redmunds included the following code: https://github.com/adobe/brackets-shell/pull/377/commits
@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Nov 12, 2013 at 17:46 GMT

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot