Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Fix potential crash when reloading Brackets #152

Open
core-ai-bot opened this issue Aug 17, 2021 · 1 comment
Open

[CLOSED] Fix potential crash when reloading Brackets #152

core-ai-bot opened this issue Aug 17, 2021 · 1 comment

Comments

@core-ai-bot
Copy link
Member

Issue by gruehle
Thursday May 23, 2013 at 21:25 GMT
Originally opened as adobe#249

When reloading Brackets, there is a short period of time where the old V8 context is still around, but has been detached from the browser. Any calls to our V8 extensions during that time will fail. Previously, this would crash. With this change, we simply ignore the request and return false to signal that we didn't handle the request.

gruehle included the following code: https://github.com/adobe/brackets-shell/pull/249/commits
@core-ai-bot
Copy link
Member Author

Comment by redmunds
Thursday May 23, 2013 at 22:10 GMT

Looks good. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot