Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoScale should not inherit from Scale #6

Open
martinRenou opened this issue Feb 3, 2020 · 1 comment
Open

GeoScale should not inherit from Scale #6

martinRenou opened this issue Feb 3, 2020 · 1 comment

Comments

@martinRenou
Copy link
Member

In d3, GeoProjections are not considered being scales. Maybe it should not inherit from the Scale, or it should share less logic with Scales in order to compile correctly (e.g. a GeoProjection does not have a range method).

@SylvainCorlay
Copy link
Member

Indeed, although it was an intentional inheritance.

Basically, d3.js does not support N-D scale, (2-D mappings that cannot be separated into x and y scales), although d3 projections are essentially just that and when we made the bqplot maps, we used the same patterns with projections as we did with scales in other marks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants