Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

getFeatureRemainings() returns error if queried against a feature with value of true/false #93

Closed
boryn opened this issue Aug 30, 2021 · 1 comment · Fixed by #94
Closed

getFeatureRemainings() returns error if queried against a feature with value of true/false #93

boryn opened this issue Aug 30, 2021 · 1 comment · Fixed by #94
Labels
bug Something isn't working patch Patch change
Milestone
v5.0.0

Comments

@boryn
Copy link
Contributor

boryn commented Aug 30, 2021

For example $subscription->getFeatureRemainings('analytics') will error with "Unsupported operand types: string - int". I think in this case we could silently return null (helpful when we are getting user's features details "in bulk")?
@bpuig bpuig added bug Something isn't working patch Patch change labels Sep 1, 2021
@bpuig bpuig added this to the v5.0.0 milestone Sep 1, 2021
@bpuig bpuig mentioned this issue Sep 5, 2021
Merged
@bpuig bpuig linked a pull request Sep 5, 2021 that will close this issue
[Fix] Get feature remainings #94
Merged
@bpuig
Copy link
Owner

bpuig commented Sep 5, 2021

Fixed in #94 , will be in next patch version for v4 and merged also to v5 development.

@bpuig bpuig closed this as completed Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working patch Patch change
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

[Fix] Get feature remainings bpuig/laravel-subby
2 participants
@boryn @bpuig