Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refiner always deduces maximal types #1

Open
radrow opened this issue Apr 9, 2021 · 2 comments
Open

Refiner always deduces maximal types #1

radrow opened this issue Apr 9, 2021 · 2 comments

Comments

@radrow
Copy link

radrow commented Apr 9, 2021

On my machine, in contrary to what it's in the README the query

target/debug/liquid-types examples/max3.ml

gives output

max_a1: F(x_a2: {ν: Int | true} → F(y_a3: {ν: Int | true} → {ν: Int | true}))

It looks like this with all examples that I tried :/

@radrow
Copy link
Author

radrow commented Apr 9, 2021

I think you messed up the split. Your map will be always empty as you add stuff to it only in unreachable case

@radrow
Copy link
Author

radrow commented Apr 9, 2021

Btw, you don't need to keep it as a map. LinkedList or even Vec would be sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant