Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Properties Panel #20

Open
pinussilvestrus opened this issue Oct 6, 2019 · 6 comments
Open

Add Properties Panel #20

pinussilvestrus opened this issue Oct 6, 2019 · 6 comments
Labels
backlog Queued in backlog enhancement New feature or request needs discussion Needs further discussion

Comments

@pinussilvestrus
Copy link
Contributor

Depends on #2

Add the bpmn-js-properties-panel to the Modeler Panel.

@pinussilvestrus pinussilvestrus added the enhancement New feature or request label Oct 6, 2019
@salaboy salaboy mentioned this issue Oct 6, 2019
4 tasks
@pinussilvestrus pinussilvestrus added this to the v0.6.0 milestone Oct 6, 2019
@pinussilvestrus pinussilvestrus modified the milestones: v0.6.0, v0.7.0 Nov 15, 2019
@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label Jan 13, 2020 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus removed this from the v0.7.0 milestone Feb 21, 2020
@mschulte
Copy link

mschulte commented Jan 7, 2021

Property-panel pretty much is needed to really make use of that plugin for devs isn't it?

@pinussilvestrus
Copy link
Contributor Author

pinussilvestrus commented Jan 7, 2021

When you want to use this plugin in an implementation context, yes, the properties panel would be very useful. Integrating it into the BPMN Modeler is not a big deal, since it's just another extension.

What we have to find out first: Which Engine Context does the Properties Panel have (Zeebe vs. Camunda vs. only BPMN)? Can this be configured? How?

Depending on the context, another properties provider will be loaded and other properties will be displayed.

@varnem2
Copy link

varnem2 commented Feb 1, 2021

Could this just be left open ended for now until a better solution is found? Maybe just be able to view/edit the XML related to that element node. Sorry, I'm not super familiar with the codebase yet.

For example, a non interrupting timer at the very least you can manually read the xml or be pointed to the xml with the implementation. In our example we can at the very least see what the implementation of the timer is, no matter the implementing process engine. Maybe just a peek view at the element's xml? Just throwing out some ideas here.

@pinussilvestrus
Copy link
Contributor Author

pinussilvestrus commented Feb 9, 2021

I could also imagine we introduce the Properties panel with general Engine agnostic support. Currently, the extension has no context in this regard. It just a basic BPMN Modeler.

Once we have camunda-bpmn-js stable, we could simply use this one and make the engine configurable in the VS Code settings.json.

@ifedavid
Copy link

ifedavid commented Apr 17, 2024

Hey, is there still a plan for this or has this been released?

I also see that a separate properties panel repo has been created - https://github.com/bpmn-io/bpmn-js-properties-panel

Would that be integrated here? Thanks

@barmac
Copy link
Member

barmac commented Apr 22, 2024

Hi,

This issue is in the backlog which means that it's not the immediate priority of our team, but we want to look into this some day, maybe. We are also happy to accept external contributions.

Since camunda-bpmn-js is a thing for some time, one could consider using that project instead of plain bpmn-js in this plugin, and add a setting in vscode to decide what kind of properties panel to show: #20 (comment)

On the other hand, we may want to display a properties panel which fits the diagram as it is done in the Desktop Modeler: https://github.com/camunda/camunda-modeler/

@barmac barmac added the needs discussion Needs further discussion label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog enhancement New feature or request needs discussion Needs further discussion
Projects
None yet
Development

No branches or pull requests

5 participants