Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the usability and general accessibility for the section contains data dot #212

Open
rpkoller opened this issue Jan 16, 2023 · 1 comment
Labels
a11y backlog Queued in backlog enhancement New feature or request

Comments

@rpkoller
Copy link

rpkoller commented Jan 16, 2023

Is your feature request related to a problem? Please describe
From a sighted users perspective for a long time i had a hard time to understand the purpose of the dark grey dot on some toggle sections. i have to admit intuitively it's meaning wasn't directly apparent and i did not come up with the idea that it might have a data tip i could surface by hovering over the dot neither.
on the other hand for screen reader users thing are even more tricky since that information is sort of none existent for them. with voiceover in safari 16.1 on macos 12.6.1 tabbing through the interface

tabs.mov

and stepping through the interface with ctrl-option-arrow right

Screen.Recording.2023-01-16.at.12.50.52.mov

the dot is none existent - due to the fact that the div is empty and only has a title the element isn't announced in each case.

Describe the solution you'd like
one option might be utilizing the same pattern suggested in #211 . the text in the span could use the micro copy Section contains data. just contains datawould be short but General contains data would sound there is only the announcment about the data instead of the section named first and then the announcement if the section contains data therefore section contains dataafter the section title might be the better choice.

Another option might be simply making the default state of the toggle sections expanded instead of collapsed. at the moment each toggle section is collapsed requiring always one extra click. or having at least the general and the documentation section expanded would be also another option. but that way the dot might be even unnecessary.

Describe alternatives you've considered

Additional context

@rpkoller rpkoller added the enhancement New feature or request label Jan 16, 2023
@barmac
Copy link
Member

barmac commented Jan 24, 2023

@YanaSegal Perhaps you can have a look at this?

I agree that the dot marker should not be inaccessible to voice over if we decide to keep it. Still, as a user I don't really see much value in having it.

@barmac barmac added backlog Queued in backlog a11y labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y backlog Queued in backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants