Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties panel module #291

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Properties panel module #291

merged 3 commits into from
Aug 23, 2022

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Jul 25, 2022

Closes #286

  • Provides Properties Panel as own module
  • Render Properties panel in Editor per default
  • Add option to render Properties Panel individually in Playground
    • Note that we still render the properties panel inside the editor in the playground as well, as I think it does not make sense to place it in the right if the preview is not collapsible
    • Note that this (and the embedded palette) will anyway be flexible to render in any other place once we tackle Playground components are freely attachable and detachable #292 as a follow up
    • This can be configured via (cf. test case)
const playground = new Playground({
  container,
  schema,
  data,
  editor: { inlinePropertiesPanel: false }
});

Run playground

npm run start:playground

Run editor

npm run start:editor

Playground default, inline properties panel

screely-1658994076433

Playground with "external" properties panel

screely-1658994163996

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 25, 2022
@pinussilvestrus pinussilvestrus changed the base branch from develop to 280-palette-module July 25, 2022 13:21
@pinussilvestrus pinussilvestrus mentioned this pull request Jul 26, 2022
@pinussilvestrus pinussilvestrus force-pushed the 286-properties-panel-module branch 2 times, most recently from 4633e78 to 94ebde3 Compare July 26, 2022 13:45
@pinussilvestrus pinussilvestrus force-pushed the 286-properties-panel-module branch 5 times, most recently from 10e82ea to 3e557e0 Compare July 28, 2022 09:03
Base automatically changed from 280-palette-module to develop July 28, 2022 09:34
@pinussilvestrus pinussilvestrus marked this pull request as ready for review July 28, 2022 10:50
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 28, 2022
@pinussilvestrus pinussilvestrus force-pushed the 286-properties-panel-module branch 5 times, most recently from db2276c to 6e66134 Compare August 4, 2022 06:31
@pinussilvestrus
Copy link
Contributor Author

Once we have #311 integrated, we need to make keyboard undo/redo explicit.

Cf. bpmn-io/diagram-js#662 (comment)

@philippfromme
Copy link
Contributor

I'm reviewing this. 👀

Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine. ™️ Good job! 🍰

@fake-join fake-join bot merged commit db18a24 into develop Aug 23, 2022
@fake-join fake-join bot deleted the 286-properties-panel-module branch August 23, 2022 14:08
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Properties Panel as own feature module
2 participants