Add accessible label to drill down button #2194
Conversation
barmac
requested review from
a team,
philippfromme,
marstamm and
nikku
and removed request for
a team
| var button = domify('<button class="bjs-drilldown">' + ARROW_DOWN_SVG + '</button>'); | ||
| var button = domify('<button type="button" class="bjs-drilldown">' + ARROW_DOWN_SVG + '</button>'), | ||
| elementName = bo.get('name') || bo.get('id'), | ||
| title = this._translate('Drill down {element}', { element: elementName }); |
There was a problem hiding this comment.
Shall this be Drill down _into_ {element}. I'd not drill down ServiceTask.
There was a problem hiding this comment.
I see. What if we called it "Open Service Task"?
There was a problem hiding this comment.
I think drill down is the word. What would be the benefit of open?
There was a problem hiding this comment.
I think "open" is much more common and therefore easier to understand. "Drill down" has always sounded unfamiliar to me.
@lmbateman Could you share your view on this?
There was a problem hiding this comment.
A couple of things to consider:
- "Drill down" may imply a deeper level of analysis than "open":
-- the Merriam-Webster dictionary defines it as "to thoroughly consider or analyze : EXAMINE".
-- The Oxford Learner's dictionary defines it as, "(computing or business) to go to deeper levels of an organized set of data in order to find more detail, especially on a computer or a website". - Typically we open links and documents, but those are usually considered peers. "Drill down" to me definitely implies a child, whereas I think "open" could refer to either a peer or child.
- My sense is that "open" might be easier for non-native speakers, and might work better for internationalization.
- I feel like I would know what "open" does, but might have a slight moment of hesitation about what "drill down" does.
Overall, I have a preference for "open" over "drill down", but not if we think "open" loses too much precision.
There was a problem hiding this comment.
Thanks Leah for your insights. I will use "open" then, but we can always change it to "drill down" if there's strong need.
There was a problem hiding this comment.
BTW we already use "Open" in dmn-js: https://github.com/bpmn-io/dmn-js/pull/843/files#diff-b5845c79db311a2ace41bb7197593074737bc342d8974b6d4069315ae7ced9ae
There was a problem hiding this comment.
Ok, so we go for "open XYZ" consistently across our tools now. I'm OK with this though drilldown in the computing or business sense makes 100% sense.
The Oxford Learner's dictionary defines it as, "(computing or business) to go to deeper levels of an organized set of data in order to find more detail, especially on a computer or a website".
Plus, the feature was referred internally as "drilldown", too, to differentiate from "open (external) resources".
barmac
force-pushed
the
fix-drilldown-label
branch
from
ea146e6
to
480f741
Compare
Proposed Changes
This PR:
axe-corewith@bpmn-io/a11yto ensure common a11y goaltitleRelated to camunda/camunda-modeler#4394
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}