Delete Vertical Lanes

[sombrek]

Closes #2081

This is a small independent fix.

[sombrek]

It seems there is some kind of rounding issue when deleting lanes that causes their boundaries to mismatch. This affects both horizontal and vertical lanes. This can probably be fixed in the future.

[barmac]

It seems there is some kind of rounding issue when deleting lanes that causes their boundaries to mismatch. This affects both horizontal and vertical lanes. This can probably be fixed in the future.

Could you please share a diagram in which you got this result? I cannot reproduce it on my own.

[sombrek]

Could you please share a diagram in which you got this result? I cannot reproduce it on my own.

Sure, it's test/spec/features/modeling/lanes/lanes.bpmn
Open it via bpmn.io then delete lane c and lane b.

I cannot reproduce it with a newly created pool. Maybe it's because of the odd dimensions in that model.

[barmac]

Thank you! I can reproduce it now. We should make sure that the child lanes don't exceed the parent lane bounds.

[barmac]

I moved this to a separate issue as it's not required for this PR: #2083

[barmac]

I'd rather move the isHorizontal call to the inside of compensateLaneDelete. There's no case where we'd pass isHorizontalLane=false for horizontal lanes to this function.

[barmac]

I will do that as a quick change.

[barmac]

Thank you! I can reproduce it now. We should make sure that the child lanes don't exceed the parent lane bounds.

BTW this bug can be noticed on the vertical lanes fixture that you're adding in this PR.

[barmac]

There is a width missmatch in the DI:

      <bpmndi:BPMNShape id="BPMNShape_140jwaa" bpmnElement="Vertical_Participant_Lane" isHorizontal="false">
        <dc:Bounds x="160" y="50" width="603" height="540" />
        <bpmndi:BPMNLabel />
      </bpmndi:BPMNShape>
      <bpmndi:BPMNShape id="BPMNShape_0n0ckvg" bpmnElement="Vertical_Lane_B" isHorizontal="false">
        <dc:Bounds x="655" y="80" width="108" height="510" />
        <bpmndi:BPMNLabel />
      </bpmndi:BPMNShape>
      <bpmndi:BPMNShape id="BPMNShape_1xhgbhc" bpmnElement="Vertical_Lane_A" isHorizontal="false">
        <dc:Bounds x="160" y="80" width="496" height="510" />
        <bpmndi:BPMNLabel />
      </bpmndi:BPMNShape>

Notice that the child lanes' widths sum up to 604 while the parent is 603.

[barmac]

I will fix the widths as well.

[barmac]

We will make it a fix when squashing.

[barmac]

Thank you @sombrek for your another great contribution!

[sombrek]

Thank you @sombrek for your another great contribution!

@barmac Thank you very much for your review, support and detail work you put into my contribution. I will learn from your remarks.