Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compensation Activity Cannot Be Appended Through Append Feature #2038

Closed
smbea opened this issue Nov 27, 2023 · 1 comment · Fixed by #2039
Closed

Compensation Activity Cannot Be Appended Through Append Feature #2038

smbea opened this issue Nov 27, 2023 · 1 comment · Fixed by #2039
Assignees
@smbea
Labels
bug Something isn't working

Comments

@smbea
Copy link
Contributor

smbea commented Nov 27, 2023

Describe the Bug

It is not possible to append a task to a Compensation Boundary Event (Compensation Activity).

Steps to Reproduce

  1. select Compensation Boundary Event
  2. open append menu
  3. try to add a task/compensation ativity

Expected Behavior

We should allow to append any Task and modify the action to add isForCompensation property.

Environment

  • Browser: [e.g. IE 11, Chrome 69]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]
@smbea smbea added bug Something isn't working ready Ready to be worked on labels Nov 27, 2023
@smbea
Copy link
Contributor Author

smbea commented Nov 30, 2023

From my undertanding, we need to:

  • Add isForCompensation to task when:
    • task is appended/connected to compensation boundary event
  • Remove isForCompensation from task when no longer connected to compensation boundary event

smbea added a commit that referenced this issue Dec 1, 2023
@smbea
fix: add isForCompensation on connect
6cad5af 
Closes #2038
@smbea smbea mentioned this issue Dec 1, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Dec 1, 2023
smbea added a commit that referenced this issue Dec 1, 2023
@smbea
fix: add isForCompensation on connect
8861ee4 
Closes #2038
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Dec 1, 2023
@smbea smbea mentioned this issue Dec 4, 2023
Closed
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 19, 2023
barmac pushed a commit that referenced this issue Dec 19, 2023
@smbea @barmac
fix: add isForCompensation on connect
e568807 
Closes #2038
barmac pushed a commit that referenced this issue Dec 21, 2023
@smbea @barmac
fix: add isForCompensation on connect
1475452 
Closes #2038
barmac added a commit that referenced this issue Dec 22, 2023
@smbea @barmac
feat: improve handling of compensation association
3dbaf50 
* Allow to connect compensate boundary event to activity, turning it into compensation activity.
* Turn sequence flow connected to boundary event into compensation association
  when boundary event is turned replaced with compensate boundary event.

Closes #2038

---------

Co-authored-by: Maciej Barelkowski <[email protected]>
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 22, 2023
@philippfromme philippfromme mentioned this issue Jan 3, 2024
Closed
36 tasks
@philippfromme philippfromme changed the title Can't add Compensation Activity via append menu Compensation Activity Cannot Be Appended Through Append Feature Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbea smbea

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve handling of compensation association bpmn-io/bpmn-js
1 participant
@smbea