feat(cloud): don't apply length and pattern validation to FEEL

[philippfromme]

Try out via npm start.

Related to camunda/camunda-modeler#4140

Proposed Changes

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[marstamm]

We do have access to the property, so we could theoretically add stricter validation with

Suggested change

	if (isFeel(value)) {
	return;
	}
	if (property.feel && isFeel(value)) {
	return;
	}

With this, this would still apply patterns to properties that are normal string type without feel expressions.

[philippfromme]

According to the schema the feel property can also be static. Would that mean the property is not FEEL? In that case we'd need to check the value of the property.

[philippfromme]

Answered. static still means it's a FEEL expression. So a simple check is enough.

[philippfromme]

One UX issue I found with this is that the error message stays until there is an actual value. There is some internal state of the FEEL entry that decides whether it's FEEL and doesn't actually commit the initial = until you enter something else like =foo. That internal state is not accessable outside of the FEEL entry. @marstamm Any idea if we can do something about that?

[marstamm]

As we have validation only when a value is persisted in other places as well (e.g. when you are still typing), I think this is fine for now. In these cases, it is basically "Should not be empty" but with another error message. I don't think this will be to confusing for the user, as the message disappears once an expression is present

[philippfromme]

@marstamm In that case it's ready for review.

[nikku]

Great change, great addition to the existing test coverage!

[nikku]

Published as https://github.com/bpmn-io/bpmn-js-element-templates/releases/tag/v2.2.0.