From fe37456654d622410234b9090436c94e8a9850da Mon Sep 17 00:00:00 2001
From: Bogdan Pintea <bogdan.pintea@elastic.co>
Date: Thu, 21 Nov 2024 13:46:27 +0100
Subject: [PATCH] ESQL: add tests on use of grouping functions in agg filters
 (#117184)

Add tests on use of grouping functions in agg filters: check that
reusing the BUCKET expression from grouping is allowed, but no other
variation.

Related: #115521
(cherry picked from commit fefa0f009fbcb786651dc2a12571f696f2f74363)
---
 .../src/main/resources/bucket.csv-spec           | 16 ++++++++++++++++
 .../xpack/esql/analysis/VerifierTests.java       |  5 +++++
 2 files changed, 21 insertions(+)

diff --git a/x-pack/plugin/esql/qa/testFixtures/src/main/resources/bucket.csv-spec b/x-pack/plugin/esql/qa/testFixtures/src/main/resources/bucket.csv-spec
index 3be3decaf351c..7bbf011176693 100644
--- a/x-pack/plugin/esql/qa/testFixtures/src/main/resources/bucket.csv-spec
+++ b/x-pack/plugin/esql/qa/testFixtures/src/main/resources/bucket.csv-spec
@@ -760,3 +760,19 @@ c:long |b:date
 3      |2025-10-01T00:00:00.000Z
 4      |2023-11-01T00:00:00.000Z
 ;
+
+bucketWithFilteredCountRefingBucket
+required_capability: implicit_casting_string_literal_to_temporal_amount
+
+FROM employees
+| STATS c = COUNT(*) WHERE b > "1953-01-01T00:00:00.000Z" AND emp_no > 10020 BY b = BUCKET(birth_date, 1 year)
+| SORT c, b
+| LIMIT 4
+;
+
+c:long |b:date
+0      |1952-01-01T00:00:00.000Z
+0      |1953-01-01T00:00:00.000Z
+0      |null
+1      |1965-01-01T00:00:00.000Z
+;
diff --git a/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java b/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
index 42cbcc6ff7623..831639bc719e6 100644
--- a/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
+++ b/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
@@ -404,6 +404,11 @@ public void testAggFilterOnBucketingOrAggFunctions() {
         query("from test | stats max(languages) WHERE bucket(salary, 10) > 1 by bucket(salary, 10)");
 
         // but fails if it's different
+        assertEquals(
+            "1:32: can only use grouping function [bucket(a, 3)] part of the BY clause",
+            error("row a = 1 | stats sum(a) where bucket(a, 3) > -1 by bucket(a,2)")
+        );
+
         assertEquals(
             "1:40: can only use grouping function [bucket(salary, 10)] part of the BY clause",
             error("from test | stats max(languages) WHERE bucket(salary, 10) > 1 by emp_no")