From 6b67ad183297de9d275e89a6fc74480bacfa43cb Mon Sep 17 00:00:00 2001 From: Conrad Chan Date: Fri, 28 Sep 2018 14:25:02 -0700 Subject: [PATCH 1/2] Update: adding the headerElement option to Preview.show --- src/lib/Preview.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/Preview.js b/src/lib/Preview.js index d582e4160..f7cc5b31d 100644 --- a/src/lib/Preview.js +++ b/src/lib/Preview.js @@ -870,6 +870,9 @@ class Preview extends EventEmitter { // Show or hide the header this.options.header = options.header || 'light'; + // Header element for when using external header outside of the provided container + this.options.headerElement = options.headerElement || options.container; + // Custom logo URL this.options.logoUrl = options.logoUrl || ''; From 934b6ff55bc924601067e65b3a02a2a959445a46 Mon Sep 17 00:00:00 2001 From: Conrad Chan Date: Mon, 1 Oct 2018 14:42:15 -0700 Subject: [PATCH 2/2] Update: remove container fallback --- src/lib/Preview.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/Preview.js b/src/lib/Preview.js index f7cc5b31d..7f27403f2 100644 --- a/src/lib/Preview.js +++ b/src/lib/Preview.js @@ -871,7 +871,7 @@ class Preview extends EventEmitter { this.options.header = options.header || 'light'; // Header element for when using external header outside of the provided container - this.options.headerElement = options.headerElement || options.container; + this.options.headerElement = options.headerElement; // Custom logo URL this.options.logoUrl = options.logoUrl || '';