diff --git a/src/lib/viewers/controls/media/MediaSettings.tsx b/src/lib/viewers/controls/media/MediaSettings.tsx index dd9ef4e91..a974956c8 100644 --- a/src/lib/viewers/controls/media/MediaSettings.tsx +++ b/src/lib/viewers/controls/media/MediaSettings.tsx @@ -39,17 +39,33 @@ export default function MediaSettings({ return ( - - + + {quality && ( )} {showAudioTrackItems && ( - + )} diff --git a/src/lib/viewers/controls/settings/SettingsFlyout.tsx b/src/lib/viewers/controls/settings/SettingsFlyout.tsx index 10efe8983..27b6d7e96 100644 --- a/src/lib/viewers/controls/settings/SettingsFlyout.tsx +++ b/src/lib/viewers/controls/settings/SettingsFlyout.tsx @@ -44,6 +44,7 @@ export default function SettingsFlyout({ 'bp-is-open': isOpen, 'bp-is-transitioning': isTransitioning, })} + data-testid="bp-settings-flyout" style={{ height, width }} > {isOpen && children} diff --git a/src/lib/viewers/controls/settings/SettingsMenuItem.tsx b/src/lib/viewers/controls/settings/SettingsMenuItem.tsx index 03163a4fd..84a2d2d64 100644 --- a/src/lib/viewers/controls/settings/SettingsMenuItem.tsx +++ b/src/lib/viewers/controls/settings/SettingsMenuItem.tsx @@ -5,7 +5,7 @@ import SettingsContext, { Menu } from './SettingsContext'; import { decodeKeydown } from '../../../util'; import './SettingsMenuItem.scss'; -export type Props = { +export type Props = React.RefAttributes & { className?: string; label: string; target: Menu; @@ -14,7 +14,7 @@ export type Props = { export type Ref = HTMLDivElement; function SettingsMenuItem(props: Props, ref: React.Ref): JSX.Element { - const { className, label, target, value } = props; + const { className, label, target, value, ...rest } = props; const { setActiveMenu } = React.useContext(SettingsContext); const handleClick = (): void => { @@ -40,6 +40,7 @@ function SettingsMenuItem(props: Props, ref: React.Ref): JSX.Element { onKeyDown={handleKeydown} role="menuitem" tabIndex={0} + {...rest} >
{label} diff --git a/src/lib/viewers/media/DashControls.tsx b/src/lib/viewers/media/DashControls.tsx index 6674da161..b37bbbc1d 100644 --- a/src/lib/viewers/media/DashControls.tsx +++ b/src/lib/viewers/media/DashControls.tsx @@ -38,7 +38,7 @@ export default function DashControls({ volume, }: Props): JSX.Element { return ( -
+
+
+
+const SETTINGS_TEMPLATE = `