Update: Support .dwg files in the DocumentViewer #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ikerr, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks! |
jeremypress
reviewed
Apr 22, 2019
src/lib/extensions.js
Outdated
| @@ -15,6 +15,7 @@ export const CODE_EXTENSIONS = [ | |||
| 'css', | |||
| 'cxx', | |||
| 'diff', | |||
| 'dwg', | |||
There was a problem hiding this comment.
CODE_EXTENSIONS are also used by the TextLoader, I think it's possible that the wrong viewer might try to load a dwg depending on order of an array.
There was a problem hiding this comment.
Ah, so should this go in DOCUMENT_EXTENSIONS instead?
There was a problem hiding this comment.
sounds good. Can DWGs have multiple pages or are they single page file types?
There was a problem hiding this comment.
They can have multiple pages.
ConradJChan
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.