Fix: Media controls now visible for videos in narrow window #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @jstoffan has signed the CLA. Thanks for the pull request! |
jeremypress
previously approved these changes
Apr 16, 2019
ConradJChan
previously approved these changes
Apr 22, 2019
jstoffan
force-pushed
the
fix-media-overflow
branch
from
e36b1a7 to
e6083cf
Compare
ConradJChan
previously approved these changes
Apr 23, 2019
jstoffan
commented
Apr 23, 2019
ConradJChan
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like vertical videos are affected due to a min-width set on the video element which maintains its aspect ratio on narrow screens. Unfortunately, this causes the media controls to overflow past the edge of the viewport.