Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Thumbnails default closed for single page docs #984

Merged
merged 3 commits into from
Apr 12, 2019

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Apr 11, 2019

For single page documents, default preview thumbnails closed

Additional benefit of this change is that the thumbnails sidebar real estate is not shown while loading the document.

TODO:

  • unit tests
  • e2e tests

default closed for single page

@boxcla
Copy link

boxcla commented Apr 11, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

jeremypress
jeremypress previously approved these changes Apr 11, 2019
@ConradJChan ConradJChan merged commit 207140b into box:master Apr 12, 2019
@ConradJChan ConradJChan deleted the default-close-single-page branch April 12, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants