Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Print poup and buffering DOM references #980

Merged
merged 4 commits into from
Apr 8, 2019
Merged

Fix: Print poup and buffering DOM references #980

merged 4 commits into from
Apr 8, 2019

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Apr 8, 2019 •
edited
Loading

Print popup is now centered with respect to the .bp div

Previously:
old print popup

Now:
after print popup

Also adjusted media styles for bp-is-buffering

TODO:

  • unit tests

@boxcla
Copy link

boxcla commented Apr 8, 2019

Verified that @ConradJChan has signed the CLA. Thanks for the pull request!

jstoffan
jstoffan previously approved these changes Apr 8, 2019
View reviewed changes
src/lib/viewers/media/_mediaBase.scss Outdated Show resolved Hide resolved
@ConradJChan ConradJChan merged commit cbc57a1 into box:master Apr 8, 2019
@ConradJChan ConradJChan deleted the fix-containers branch April 8, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ConradJChan @boxcla @jstoffan